fix: incorrect account type #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be "ed25519", as the default keyring type was used.
|
@BeroBurny @irubido can you help with this ? Thank you |
It has been a long time since I worked on that feature, can you please explain the reasoning or point to the documentation? |
BeroBurny
approved these changes
Jul 1, 2024
|
Hey @BeroBurny, you can see here where the keyring is instantiated. And if you don't specify a type, the default value will be used: |
Merged
BeroBurny
pushed a commit
that referenced
this pull request
Jul 24, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>metamask-polkadot-adapter: 0.8.0</summary> ## [0.8.0](metamask-polkadot-adapter-v0.7.0...metamask-polkadot-adapter-v0.8.0) (2024-07-03) ### Features * add genesis hash to injected accounts ([#236](#236)) ([bc73e6c](bc73e6c)) ### Bug Fixes * incorrect account type ([#237](#237)) ([ae02ce9](ae02ce9)) </details> <details><summary>metamask-polkadot-types: 0.9.0</summary> ## [0.9.0](metamask-polkadot-types-v0.8.0...metamask-polkadot-types-v0.9.0) (2024-07-03) ### Features * add genesis hash to injected accounts ([#236](#236)) ([bc73e6c](bc73e6c)) </details> <details><summary>polkadot-snap: 0.11.0</summary> ## [0.11.0](polkadot-snap-v0.10.0...polkadot-snap-v0.11.0) (2024-07-03) ### Features * add genesis hash to injected accounts ([#236](#236)) ([bc73e6c](bc73e6c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be "ed25519", as the default keyring type was used.