feat: add genesis hash to injected accounts

[tien]

DApp will use this to determine which network can the account be used with. This is especially important in this case, as accounts are always restricted to one network.

[CLAassistant]

All committers have signed the CLA.

[BeroBurny]

Hey. Thanks for taking the time to contribute.

There is an issue I see the genesisHash will be part of the account only in case if is provided by config and only that hash.
Is that intentional? If not what is intention?

[tien]

Hey. Thanks for taking the time to contribute.

There is an issue I see the genesisHash will be part of the account only in case if is provided by config and only that hash. Is that intentional? If not what is intention?

Hey @BeroBurny, for example, if the account has the "Kusama genesis hash" attached to it, DApp will know that the account can only sign Kusama transaction. Which is true for this snap because enablePolkadotSnap accept a config of 1 network only.

[BeroBurny]

Hey. Thanks for taking the time to contribute.
There is an issue I see the genesisHash will be part of the account only in case if is provided by config and only that hash. Is that intentional? If not what is intention?

Hey @BeroBurny, for example, if the account has the "Kusama genesis hash" attached to it, DApp will know that the account can only sign Kusama transaction. Which is true for this snap because enablePolkadotSnap accept a config of 1 network only.

That will work if the user provide config, but in case there is no config provided value will be undefined as is not sent from snap to client (adapter)

[Lykhoyda]

Agree with @BeroBurny please take care of his comment

reset

[tien]

Thanks for the review, I have made genesisHash mandatory for custom network 🙏.

[BeroBurny]

Thanks for the review, I have made genesisHash mandatory for custom network 🙏.

My bad seems I miscommunicated the issue.

Let us begin with the basics, snap is like a microservice. The browser is calling an extension and we get data back.

User => Browser <=> Snap

So the adapter lives in the browser and snaps inside MetaMask.
With the current setup browser never gets configured from snap, as there is no method to retrieve it. So adding data to config in a snap is not going to do anything on the adapter part and the browser in this case only gets the user address but no information about the genesis.

So current solution to that falls on top of my head.
a) Implement retrieving config method
b) Include genesis hash in response to getAddress
c) Open the issue and hope someone solves the problem

[tien]

Alright, thanks for the clarification, would you say option a make the most sense here? @BeroBurny

[BeroBurny]

Great Job, Thanks for taking the time :)

@Lykhoyda @irubido Please check it if I missed something

[irubido]

Looks good to me, genesisHash as requirement for custom config 👍