feat: export account json rpc #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrunic
previously approved these changes
Jun 17, 2024
irubido
changed the title
BeroBurny
requested changes
Jun 18, 2024
| @@ -70,6 +70,16 @@ export async function exportSeed(this: MetamaskPolkadotSnap): Promise<string> { | |||
| return (await sendSnapMethod({ method: 'exportSeed' }, this.snapId)) as string; | |||
| } | |||
|
|
|||
| export async function exportAccount( | |||
| this: MetamaskPolkadotSnap, | |||
| jsonPassphrase?: string | |||
There was a problem hiding this comment.
Remove jsonPassphrase there is no usage of it in snap
There was a problem hiding this comment.
Left it optional because polkadot js extension must have a passphrase to successfully import account.
Leaving it as empty field does not allow restoring.
There was a problem hiding this comment.
but like reviewing exportAccount.test.ts seems like there is no point of using it
If the extension uses a password field that is not used anywhere (bad U, itX) should not affect our API
There was a problem hiding this comment.
Why we wouldn't allow this option, we lose nothing extending the already existing
KeyringPair.toJson(passphrase?: string) method.
mpetrunic
previously approved these changes
Jun 18, 2024
irubido
dismissed
mpetrunic’s stale review
The merge-base changed after approval.
irubido
changed the title
BeroBurny
approved these changes
Jun 18, 2024
Merged
irubido
pushed a commit
that referenced
this pull request
Jun 19, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>metamask-polkadot-adapter: 0.7.0</summary> ## [0.7.0](metamask-polkadot-adapter-v0.6.0...metamask-polkadot-adapter-v0.7.0) (2024-06-18) ### Features * export account json rpc ([#234](#234)) ([0212428](0212428)) </details> <details><summary>metamask-polkadot-types: 0.8.0</summary> ## [0.8.0](metamask-polkadot-types-v0.7.0...metamask-polkadot-types-v0.8.0) (2024-06-18) ### Features * export account json rpc ([#234](#234)) ([0212428](0212428)) </details> <details><summary>polkadot-snap: 0.10.0</summary> ## [0.10.0](polkadot-snap-v0.9.0...polkadot-snap-v0.10.0) (2024-06-18) ### Features * export account json rpc ([#234](#234)) ([0212428](0212428)) ### Bug Fixes * exportSeed coin type fix ([#233](#233)) ([7bef7c2](7bef7c2)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains changes from #233
new rpc returns stringified json of keyring pair
example implements file saver and json passphrase encoding field