fix: exportSeed coin type fix (#233)

remove hardcoded kusama coinType, uses `coinType` based on configuration
ChainSafe · Jun 18, 2024 · 7bef7c2 · 7bef7c2
1 parent 3c78592
commit 7bef7c2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/packages/snap/snap.manifest.json b/packages/snap/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "git+https://github.com/chainsafe/metamask-snap-polkadot.git"
   },
   "source": {
-    "shasum": "tetP/U2cSxYl1CqUrLT+d1HD74GQyUy/MDUQ7h7qlEQ=",
+    "shasum": "VLA9zcJiR3GjrTia+9M5lgWjqwSZ8pCrAPrH39BUTrU=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

diff --git a/packages/snap/src/rpc/exportSeed.ts b/packages/snap/src/rpc/exportSeed.ts
@@ -1,9 +1,12 @@
 import type { JsonBIP44CoinTypeNode } from '@metamask/key-tree';
 import { showConfirmationDialog } from '../util/confirmation';
-
-const kusamaCoinType = 434;
+import { getConfiguration } from '../configuration';
+import { getCoinTypeByNetwork } from '../polkadot/account';
 
 export async function exportSeed(): Promise<string | null> {
+  const configuration = await getConfiguration();
+  const coinType = getCoinTypeByNetwork(configuration.networkName);
+
   // ask for confirmation
   const confirmation = await showConfirmationDialog({
     prompt: 'Do you want to export your seed?'
@@ -12,7 +15,7 @@ export async function exportSeed(): Promise<string | null> {
   if (confirmation) {
     const bip44Node = (await snap.request({
       method: 'snap_getBip44Entropy',
-      params: { coinType: kusamaCoinType }
+      params: { coinType: coinType }
     })) as JsonBIP44CoinTypeNode;
     return bip44Node.privateKey.slice(0, 32);
   }

diff --git a/packages/snap/test/unit/rpc/exportSeed.test.ts b/packages/snap/test/unit/rpc/exportSeed.test.ts
@@ -13,9 +13,9 @@ describe('Test rpc handler function: exportSeed', function () {
   });
 
   it('should return seed on positive prompt confirmation and keyring saved in state', async function () {
-    walletStub.request.onFirstCall().returns(true);
+    walletStub.request.onSecondCall().returns(true);
     walletStub.request
-      .onSecondCall()
+      .onThirdCall()
       .returns({ privateKey: 'aba2dd1a12eeafda3fda62aa6dfa21ca2aa6dfaba13fda6a22ea2dd1eafda1ca' });
     const result = await exportSeed();
     expect(result).to.be.eq('aba2dd1a12eeafda3fda62aa6dfa21ca');
@@ -24,7 +24,7 @@ describe('Test rpc handler function: exportSeed', function () {
   it('should not return seed on negative prompt confirmation', async function () {
     walletStub.request.returns(false);
     const result = await exportSeed();
-    expect(walletStub.request).to.have.been.calledOnce;
+    expect(walletStub.request).to.have.been.calledTwice;
     expect(result).to.be.eq(null);
   });
 });