feat: remove publicKeyAtInfinity check
#60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q9f
reviewed
Sep 25, 2023
- The rust implementation don't have this check - https://github.com/w3f/schnorrkel/blob/38035b50f49ecc40e10831bb8c11b59c143b7aa9/src/sign.rs#L230 - This check was impacting the signature verification of block `#8077850` on westend network
EclesioMeloJunior
force-pushed
the
eclesio/remove-publicKeyAtInfinity
branch
from
2200222
to
e704f9d
Compare
dimartiro
approved these changes
Sep 25, 2023
jimjbrettj
approved these changes
Sep 25, 2023
|
@noot we would like to understand more about this check and what kind of implications it was trying to cover. |
|
ref #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8077850on Westend network#8077850has an extrinsic in which the public key signer contains all zeroes and this is hitting thepublicKeyAtInfinitycheck, removing this check (that doesn't exist in rust version) it passes.