feat(f3): add f3_* fields to chain config #4871
Conversation
src/networks/mod.rs
Outdated
| @@ -249,6 +252,13 @@ impl ChainConfig { | |||
| breeze_gas_tamping_duration: BREEZE_GAS_TAMPING_DURATION, | |||
| // 1 year on mainnet | |||
| fip0081_ramp_duration_epochs: 365 * EPOCHS_IN_DAY as u64, | |||
| f3_bootstrap_epoch: -1, | |||
| f3_initial_power_table: Default::default(), | |||
| f3_mainfest_server: Some( | |||
There was a problem hiding this comment.
These values are from Lotus but I suspect f3_mainfest_server will be deprecated once F3 is fully bootstrapped to avoid single point network dependencies
There was a problem hiding this comment.
It'd best to put this comment in the code.
hanabi1224
force-pushed
the
hm/add-f3-options-to-chain-config
branch
from
61bc273
to
e165f00
Compare
hanabi1224
requested review from
ruseinov and
LesnyRumcajs
and removed request for
a team
|
you likely need to add those env variables to the forest docs repo as well. |
@ruseinov Done in https://github.com/ChainSafe/forest-docs-v2/pull/90 |
src/daemon/mod.rs
Outdated
| @@ -428,21 +427,46 @@ pub(super) async fn start( | |||
| None | |||
| } | |||
| }) | |||
| .inspect(|i| { | |||
There was a problem hiding this comment.
It'd be great to de-clunk this method which is already pretty bloated. How about moving the F3 init + config + service into f3/?
For readability, I'd imagine the end the end usage to be along lines of:
services.spawn_block({
f3::service(...)
})After moving it into a separate module, it'd be great to have some basic unit tests if possible.
There was a problem hiding this comment.
de-clunked the method and added unit test
Summary of changes
Changes introduced in this pull request:
f3_bootstrap_epochfield toChainConfigFOREST_F3_BOOTSTRAP_EPOCHenvironment variablef3_initial_power_tablefield toChainConfigf3_mainfest_serverfield toChainConfigReference issue to close (if applicable)
Closes #4870
Other information and links
Change checklist