Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update FVM #4859

Merged
merged 9 commits into from
Oct 9, 2024
Merged

chore: update FVM #4859

merged 9 commits into from
Oct 9, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Oct 8, 2024

Summary of changes

Changes introduced in this pull request:

  • updated FVM to the latest version as required by the NV24 upgrade,
  • updated fil-actor-states deps to unblock the bump,
  • removed the testing feature for FVM builds outside of tests.

Reference issue to close (if applicable)

Closes #4806

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner October 8, 2024 15:56
@LesnyRumcajs LesnyRumcajs requested review from lemmih and sudo-shashank and removed request for a team October 8, 2024 15:56
@LesnyRumcajs
Copy link
Member Author

Hmm, perhaps even if it compiles, it doesn't necessarily mean that it works. I'll investigate tomorrow.

@LesnyRumcajs LesnyRumcajs marked this pull request as draft October 8, 2024 17:23
auto-merge was automatically disabled October 8, 2024 17:23

Pull request was converted to draft

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review October 9, 2024 12:09
@lemmih
Copy link
Contributor

lemmih commented Oct 9, 2024

Nice, you got rid of the testing feature flag. Let's get rid of this comment:

// JANK(aatifsyed): Why are we using a testing build of fvm_shared?

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 00c52a4 Oct 9, 2024
33 checks passed
@LesnyRumcajs LesnyRumcajs deleted the update-fvm branch October 9, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV24] update to latest FVM
4 participants