-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to snark-verifier
Solidity contracts
#61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nulltea
requested review from
ec2 and
willemolding
and removed request for
willemolding
February 21, 2024 13:15
ec2
reviewed
Feb 21, 2024
lightclient-circuits/tests/step.rs
Outdated
// Code: https://github.com/ChainSafe/Spectre | ||
// SPDX-License-Identifier: LGPL-3.0-only | ||
|
||
use ark_std::{end_timer, start_timer}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget to uncomment
nulltea
force-pushed
the
nulltea/misc-fixes
branch
from
February 21, 2024 15:00
1c7a082
to
db27c3e
Compare
nulltea
force-pushed
the
nulltea/misc-fixes
branch
from
February 21, 2024 15:11
db27c3e
to
c41329f
Compare
ec2
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to regular Sol contracts generated by
snark-verifier
and adds manual instances parcing in Spectre.sol.Step gas cost:
345,618
(before400,526
)Rotate gas cost:
670,586
(before766,145
)This also removes patches of
snark-verifier
.Constracrs are moved to
https://github.com/ChainSafe/spectre-contracts
and added here as submodule