-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSZ Multiproof #57
base: develop
Are you sure you want to change the base?
SSZ Multiproof #57
Conversation
.as_ref() | ||
.iter() | ||
.map(|v| builder.main().load_witness(F::from(*v as u64))) | ||
.collect_vec(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have this in 5 or more places now (incl step circuit), might be worth putting this in a util method for this?
I've removed the patch to halo2curves in the PR as well :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point re. code repetition still stands. Otherwise LGMT
TODO:
[x] Clean up some duplicate code
[x] Consider removing some of the preprocessor tests which only test individual circuits
[x] Fix spec tests
This PR reduces the amount of advice cells being used. We merklize a whole beacon header in circuit when what we really want is just a merkle proof for a couple specific fields.
Before:
After: