Various UI and test fixes #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Tbaut
commented
Apr 9, 2024
•
Tbaut
commented
- remove indexer logs
- remove Kilt indexer until someone says they want it
- fix copy tooltip not disappearing
- remove cy.clock that's useless in tests and close the banner manually instead
- silences a warning in the console
Tbaut
commented
Apr 9, 2024
| @@ -263,6 +263,9 @@ describe('Account address in the address bar', () => { | |||
|
|
|||
| topMenuItems.desktopMenu().within(() => topMenuItems.networkSelector().click()) | |||
| topMenuItems.networkSelectorOption('kusama').click() | |||
| landingPage | |||
There was a problem hiding this comment.
@asnaith this actually made it so that it'd have failed earlier, I tested by removing my fix. It's better than having to wait 2s on purpose.
Tbaut
commented
Apr 9, 2024
|
|
||
| cy.clock().then((clock) => { |
There was a problem hiding this comment.
this wasn't working. Adding the cy.clock before the cy.visit actually breaks everything, somehow, as the api calls don't get fired. All in all removing the clock
Tbaut
commented
Apr 9, 2024
|
|
||
| export const waitForMultisigLength = (length: number) => | ||
| cy.waitUntil(() => { | ||
| multisigPage.accountHeader().click() |
There was a problem hiding this comment.
this is doing a click outside basically, so that if any dropdown is open, it's close it.
There was a problem hiding this comment.
Sounds good, might be worth adding a small comment there about that so we remember why we are doing that.
asnaith
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.