Support removeProxies
in the indexer
#285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #283
This is non trivial to properly test, due to the way the indexer works. There are 3 types of scenarios:
proxy.removeProxies
now, on an old pure, that is already persisted in the DBproxy.removeProxies
will be in a batch with potentially many other proxies creation/deletionproxy.removeProxies
, and we re-index the chain (like on 2). Then the new proxy or the pure will never even touch the DB. The removal will happen in a batch array.I've carefully tested all these scenarios. There is no easy way to test 2 and 3 because it requires a re-indexing, which happens every month, when we have changes in the indexer.
In any case the deployment of the test UI is now pointing to the new (v2) of the indexer that supports it. @LernaJ you should not see the pure proxies any more (the multisig are here still though)