Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TrackingReferenceFrame.ENU #12314

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

jfayot
Copy link
Contributor

@jfayot jfayot commented Nov 19, 2024

Description

Follows-up #12194 .
Added TrackingReferenceFrame.ENU to allow tracking entities in their local East-North-Up reference frame.

Issue number and link

Fixes #12313

Testing plan

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @jfayot!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor

ggetz commented Nov 20, 2024

Thanks for the additional PR @jfayot! Glad to hear this is working for #12313.

The code overall is looking great! Could we please note the additional fix in CHANGES.md? It night help give context to users with similar issues.

@jfayot jfayot force-pushed the feat_tracking_reference_frame branch from c4c9359 to 2715500 Compare November 21, 2024 07:34
@jfayot
Copy link
Contributor Author

jfayot commented Nov 21, 2024

@ggetz , I've updated the CHANGES.md file with the possible values that can take Entity.trackingReferenceFrameand a note on possible camera orientation flip when auto-detect algorithm is used.
That made me think that another tracking reference frame could be proposed: VVLH, which is only available through AUTODETECT right now.
What do you think?

@ggetz
Copy link
Contributor

ggetz commented Nov 21, 2024

@jfayot That works! I think after that, all options are covered.

@jfayot
Copy link
Contributor Author

jfayot commented Nov 21, 2024

@ggetz I realized that I got ahead of myself while proposing this TrackingReferenceFrame.VVLH: if TrackingReferenceFrame.ENU makes sense, it's because you can define ENU at any point whatever the dynamic of the entity is. However it goes differently for VVLH, this kind of reference frame cannot be defined at any condition! I guess this explains the reason for auto-detect: ENU acts as a fallback where VVLH cannot be defined.
But a pure VVLH makes no sense...

@ggetz
Copy link
Contributor

ggetz commented Nov 22, 2024

Got it. The rest of the changes are all looking good. Thanks @jfayot!

@ggetz ggetz added this pull request to the merge queue Nov 22, 2024
Merged via the queue into CesiumGS:main with commit 90a17ef Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracked Entity Orientation Flip
2 participants