Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix smooth normals crash #739

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Fix smooth normals crash #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

### v0.24.0 - 2024-11-01

* Fixed bug where smooth normals setting would crash.

### v0.23.0 - 2024-10-01

* Fixed bug where tilesets and raster overlays were not being passed the correct custom ellipsoid.
Expand Down
2 changes: 1 addition & 1 deletion src/core/src/FabricVertexAttributeAccessors.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ NormalsAccessor NormalsAccessor::GenerateSmooth(const PositionsAccessor& positio
}

auto accessor = NormalsAccessor();
accessor._size = normals.size();
accessor._computed = std::move(normals);
accessor._size = indices.size();
return accessor;
}

Expand Down
Loading