Abstracted out wheel installation #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weegeekps
requested review from
lilleyse,
r-veenstra,
corybarr and
mattelser
as code owners
weegeekps
changed the title
lilleyse
reviewed
Jul 24, 2023
There was a problem hiding this comment.
This is a dependency for pyproj. It's just the Mozilla certs we already bundle a different way.
I looked at potential methods for replacing what we are doing with this and came up short. The way this package works will only work for Python.
|
@weegeekps just that one comment from me, looks great |
lilleyse
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts out the vendor wheel installation a bit, so we can have each extension handle it's own wheels.
As an example, I also went ahead and added
pyprojand it's dependency tocesium.powertools. Dependencies just need to be included, and don't necessarily need to be manually installed.This has been tested in both Linux and Windows, but it would be good if other's could test this on their systems as well.