Merge branch 'main' into kit-106-update

CesiumGS · Oct 6, 2024 · b9556fd · b9556fd
2 parents abcaa7b + e55dc6e
commit b9556fd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -3,6 +3,7 @@
 ### v0.24.0 - 2024-11-01
 
 * **Breaking change:** Cesium for Omniverse now requires Kit 106.0 or above (Isaac Sim 4.0.0 or above).
+* Fixed bug where smooth normals setting would crash.
 
 ### v0.23.0 - 2024-10-01
 

diff --git a/src/core/src/FabricVertexAttributeAccessors.cpp b/src/core/src/FabricVertexAttributeAccessors.cpp
@@ -163,8 +163,8 @@ NormalsAccessor NormalsAccessor::GenerateSmooth(const PositionsAccessor& positio
     }
 
     auto accessor = NormalsAccessor();
+    accessor._size = normals.size();
     accessor._computed = std::move(normals);
-    accessor._size = indices.size();
     return accessor;
 }