Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way I could figure out to constrain the constructor not to modify state… But! One of the ghosts was originally written in a way that using
SSTORE
on the same slot of_voted
causes the voters count to be increased by 1… It's not possible to exploit because the original program wouldn't invoke_voted
SSTORE
twice, nevertheless we can trick it a bit. So merging those two issues in spec, we can do what just happened here.This change needs to be in constructor because the
vote
function is heavily constrained and spec wouldn't allow for arbitraryvoteTo
invocation there, or anywhere else in functions.