Skip to content

Commit

Permalink
fix: Fix solc warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelmtzinf committed Sep 13, 2024
1 parent c8b9c61 commit c9d5f9b
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/contracts/misc/GhoAaveSteward.sol
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {IPoolAddressesProvider} from '@aave/core-v3/contracts/interfaces/IPoolAd
import {IPool} from '@aave/core-v3/contracts/interfaces/IPool.sol';
import {DataTypes} from '@aave/core-v3/contracts/protocol/libraries/types/DataTypes.sol';
import {ReserveConfiguration} from '@aave/core-v3/contracts/protocol/libraries/configuration/ReserveConfiguration.sol';
import {IPoolConfigurator, IDefaultInterestRateStrategyV2, DefaultReserveInterestRateStrategyV2} from './dependencies/AaveV3-1.sol';
import {IPoolConfigurator, IDefaultInterestRateStrategyV2} from './dependencies/AaveV3-1.sol';
import {IGhoAaveSteward} from './interfaces/IGhoAaveSteward.sol';
import {RiskCouncilControlled} from './RiskCouncilControlled.sol';

Expand Down
3 changes: 0 additions & 3 deletions src/test/TestGhoAaveSteward.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -661,9 +661,6 @@ contract TestGhoAaveSteward is TestGhoBase {
}

function testRevertUpdateGhoBorrowRateIfValueMoreThanMax() public {
address currentInterestRateStrategy = POOL.getReserveInterestRateStrategyAddress(
address(GHO_TOKEN)
);
uint32 maxGhoBorrowRate = GHO_BORROW_RATE_MAX;
_setGhoBorrowRateViaConfigurator(maxGhoBorrowRate);
vm.prank(RISK_COUNCIL);
Expand Down
3 changes: 1 addition & 2 deletions src/test/mocks/MockUpgradeableBurnMintTokenPool.sol
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ contract MockUpgradeableBurnMintTokenPool is Initializable {
address router,
uint256 bridgeLimit
) public virtual initializer {
allowlist;
if (owner == address(0)) revert ZeroAddressNotAllowed();
if (router == address(0)) revert ZeroAddressNotAllowed();
_transferOwnership(owner);
Expand All @@ -77,12 +78,10 @@ contract MockUpgradeableBurnMintTokenPool is Initializable {

function setBridgeLimit(uint256 newBridgeLimit) external {
if (msg.sender != s_bridgeLimitAdmin && msg.sender != owner()) revert Unauthorized(msg.sender);
uint256 oldBridgeLimit = s_bridgeLimit;
s_bridgeLimit = newBridgeLimit;
}

function setBridgeLimitAdmin(address bridgeLimitAdmin) external {
address oldAdmin = s_bridgeLimitAdmin;
s_bridgeLimitAdmin = bridgeLimitAdmin;
}

Expand Down
3 changes: 1 addition & 2 deletions src/test/mocks/MockUpgradeableLockReleaseTokenPool.sol
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ contract MockUpgradeableLockReleaseTokenPool is Initializable {
address router,
uint256 bridgeLimit
) public virtual initializer {
allowlist;
if (owner == address(0)) revert ZeroAddressNotAllowed();
if (router == address(0)) revert ZeroAddressNotAllowed();
_transferOwnership(owner);
Expand All @@ -77,12 +78,10 @@ contract MockUpgradeableLockReleaseTokenPool is Initializable {

function setBridgeLimit(uint256 newBridgeLimit) external {
if (msg.sender != s_bridgeLimitAdmin && msg.sender != owner()) revert Unauthorized(msg.sender);
uint256 oldBridgeLimit = s_bridgeLimit;
s_bridgeLimit = newBridgeLimit;
}

function setBridgeLimitAdmin(address bridgeLimitAdmin) external {
address oldAdmin = s_bridgeLimitAdmin;
s_bridgeLimitAdmin = bridgeLimitAdmin;
}

Expand Down

0 comments on commit c9d5f9b

Please sign in to comment.