Formating prints according to CERT-7899 #61
Conversation
Co-authored-by: yoav-el-certora <[email protected]>
Quorum/checks/price_feed.py
Outdated
| coingecko_name = CoinGeckoAPI().get_name() | ||
| token_validation_res = {r for r in overall_verified_vars if r.found_on == coingecko_name} | ||
| price_feed_validation_res = overall_verified_vars - token_validation_res | ||
|
|
||
| # Print price feed validation | ||
| pp.pprint('Price feed validation', pp.Colors.INFO) | ||
| msg = (f'{len(price_feed_validation_res)}/{num_addresses} ' | ||
| 'were identified as price feeds of the configured providers:\n') | ||
| for i, var_res in enumerate(price_feed_validation_res, 1): | ||
| msg += (f'\t{i}. {var_res.address} found on {var_res.found_on}\n' | ||
| f"\t Name: {var_res.price_feed['name']}\n" | ||
| f"\t Decimals: {var_res.price_feed['decimals']}\n") | ||
| pp.pprint(msg, pp.Colors.SUCCESS) | ||
|
|
||
| # Print token validation | ||
| pp.pprint('Token validation', pp.Colors.INFO) | ||
| msg = (f'{len(token_validation_res)}/{num_addresses} ' | ||
| 'were identified as tokens of the configured providers:\n') | ||
| for i, var_res in enumerate(token_validation_res, 1): | ||
| msg += (f'\t{i}. {var_res.address} found on {var_res.found_on}\n' | ||
| f"\t Name: {var_res.price_feed['name']}\n" | ||
| f"\t Symbol: {var_res.price_feed['pair']}\n" | ||
| f"\t Decimals: {var_res.price_feed['decimals']}\n") | ||
| pp.pprint(msg, pp.Colors.SUCCESS) |
There was a problem hiding this comment.
If we decide to go with that insanity eventually, lets do it properly by split the logic for the entry point to the check in order to achieve a general solution which will support additional providers by not import them and check for their name every time. @yoav-el-certora Feel free to decide whether you want this change as part of this PR or open different ticket which i can take later.
There was a problem hiding this comment.
I think that I commented/asked this in your previous PR when splitting providers to price feed and tokens.
Lets create a subtask for this.
Great point
There was a problem hiding this comment.
Yes I actually wanted to do this but didn't want to take it too far though in this ticket so it wouldn't get prolonged. I aim to do at as another ticket later @yoav-el-certora.
Quorum/checks/price_feed.py
Outdated
| ''' | ||
| address: str | ||
| found_on: str | ||
| price_feed: dict |
There was a problem hiding this comment.
Use the original pydantic class insead of the dict as its more structured approach.
No description provided.