Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CERT 7877 Split address validation providers #46

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

nivcertora
Copy link
Collaborator

@nivcertora nivcertora requested a review from a team as a code owner December 26, 2024 15:53
@nivcertora nivcertora self-assigned this Dec 26, 2024
Copy link
Collaborator

@yoav-el-certora yoav-el-certora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks fine for me, just wondering if there is or will be any difference between the 2 providers lists, if we do expect differences, we should probably split implementation as well.

@nivcertora
Copy link
Collaborator Author

Basically looks fine for me, just wondering if there is or will be any difference between the 2 providers lists, if we do expect differences, we should probably split implementation as well.

Strongly disagree with changing the correct code logic for the wrong "UX" description.

@yoav-el-certora
Copy link
Collaborator

It all depends if price_feed_providers and token_validation_providers will require different checks in the future as stated in the ticket, waiting for @MichaelMorami response

@nivcertora nivcertora merged commit cf820a2 into main Dec 29, 2024
1 check passed
@nivcertora nivcertora deleted the niv/CERT-7877-Split-Providers branch December 29, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants