Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address filter from comments #43

Merged
merged 14 commits into from
Dec 29, 2024

Conversation

nivcertora
Copy link
Collaborator

@nivcertora nivcertora self-assigned this Dec 26, 2024
@nivcertora nivcertora requested a review from a team as a code owner December 26, 2024 14:23
Copy link
Collaborator

@yoav-el-certora yoav-el-certora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks great.
Please add a test which verify different comments versions are being caught properly.

liav-certora
liav-certora previously approved these changes Dec 29, 2024
Copy link
Contributor

@liav-certora liav-certora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nivcertora nivcertora merged commit bb97d09 into main Dec 29, 2024
1 check passed
@nivcertora nivcertora deleted the niv/CERT-7873-Fix-Address-Extraction branch December 29, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants