Documentation for trusted method analysis #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urikirsh
approved these changes
Dec 18, 2024
| potentially untrusted. | ||
|
|
||
| I.e. a method call is trusted iff at the call site: | ||
| 1. the target contract address is resolvable and is known to be a fixed address (along all possible execution path) _and_ |
There was a problem hiding this comment.
Suggested change
| 1. the target contract address is resolvable and is known to be a fixed address (along all possible execution path) _and_ | |
| 1. the target contract address is resolvable and is known to be a fixed address (along all possible execution paths) _and_ |
|
|
||
| I.e. a method call is trusted iff at the call site: | ||
| 1. the target contract address is resolvable and is known to be a fixed address (along all possible execution path) _and_ | ||
| 2. the method sighash is resolvable and is known to be fixed (also along all possible execution path) _and_ |
There was a problem hiding this comment.
Suggested change
| 2. the method sighash is resolvable and is known to be fixed (also along all possible execution path) _and_ | |
| 2. the method sighash is resolvable and is known to be fixed (also along all possible execution paths) _and_ |
| "prover_resource_files": ["trustedMethods:ExampleTrustedMethod.json"], | ||
| ``` | ||
|
|
||
| 3. Create a file called `ExampleTrustedMethod.json` in the folder you are executing `certoraRun` command from. Within the file |
There was a problem hiding this comment.
Suggested change
| 3. Create a file called `ExampleTrustedMethod.json` in the folder you are executing `certoraRun` command from. Within the file | |
| 3. Create a file called `ExampleTrustedMethod.json` in the folder from which you are executing the `certoraRun` command. Within the file |
| "0x5aAeb6053F3E94C9b9A09f33669435E7Ef1BeAed": ["0x7e2a6db8","0xb23d4266"] | ||
| } | ||
| ``` | ||
| Here `["0x7e2a6db8","0xb23d4266"]` is the list of methods with signatures `["trusted()","untrusted()"]`. |
There was a problem hiding this comment.
A bit weird to use the function untrusted() as an example of a trusted command, maybe better to use a different name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for a new built in rule to detect trusted and untrusted methods.