Skip to content
GitHub Actions / clippy succeeded Aug 10, 2023 in 0s

clippy

14 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 14
Note 0
Help 0

Versions

  • rustc 1.73.0-nightly (08d00b40a 2023-08-09)
  • cargo 1.73.0-nightly (d78bbf4bd 2023-08-03)
  • clippy 0.1.73 (08d00b4 2023-08-09)

Annotations

Check warning on line 455 in crates/jrsonnet-evaluator/src/typed/conversions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> crates/jrsonnet-evaluator/src/typed/conversions.rs:437:3
    |
437 | /         match &value {
438 | |             Val::Arr(a) => {
439 | |                 if let Some(bytes) = a.as_any().downcast_ref::<BytesArray>() {
440 | |                     return Ok(bytes.0.as_slice().into());
...   |
454 | |             }
455 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else
    = note: `#[warn(clippy::single_match_else)]` implied by `#[warn(clippy::pedantic)]`
help: try
    |
437 ~         if let Val::Arr(a) = &value {
438 ~                   if let Some(bytes) = a.as_any().downcast_ref::<BytesArray>() {
439 ~                       return Ok(bytes.0.as_slice().into());
440 ~                   };
441 ~                   <Self as Typed>::TYPE.check(&value)?;
442 ~                   // Any::downcast_ref::<ByteArray>(&a);
443 ~                   let mut out = Vec::with_capacity(a.len());
444 ~                   for e in a.iter() {
445 ~                       let r = e?;
446 ~                       out.push(u8::from_untyped(r)?);
447 ~                   }
448 ~                   Ok(out.as_slice().into())
449 ~               } else {
450 ~                   <Self as Typed>::TYPE.check(&value)?;
451 ~                   unreachable!()
452 ~               }
    |

Check warning on line 643 in crates/jrsonnet-evaluator/src/obj.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant clone

warning: redundant clone
   --> crates/jrsonnet-evaluator/src/obj.rs:643:31
    |
643 |                 let entry = out.entry(name.clone());
    |                                           ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> crates/jrsonnet-evaluator/src/obj.rs:643:27
    |
643 |                 let entry = out.entry(name.clone());
    |                                       ^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

Check warning on line 504 in crates/jrsonnet-evaluator/src/obj.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant clone

warning: redundant clone
   --> crates/jrsonnet-evaluator/src/obj.rs:504:31
    |
504 |                 let entry = out.entry(name.clone());
    |                                           ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> crates/jrsonnet-evaluator/src/obj.rs:504:27
    |
504 |                 let entry = out.entry(name.clone());
    |                                       ^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

Check warning on line 483 in crates/jrsonnet-evaluator/src/obj.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

question mark operator is useless here

warning: question mark operator is useless here
   --> crates/jrsonnet-evaluator/src/obj.rs:483:5
    |
483 |                 Ok(self.obj.get_or_bail(self.key)?)
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `self.obj.get_or_bail(self.key)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
note: the lint level is defined here
   --> crates/jrsonnet-evaluator/src/lib.rs:5:2
    |
5   |     clippy::all,
    |     ^^^^^^^^^^^
    = note: `#[warn(clippy::needless_question_mark)]` implied by `#[warn(clippy::all)]`

Check warning on line 404 in crates/jrsonnet-evaluator/src/obj.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `unwrap_or` followed by a function call

warning: use of `unwrap_or` followed by a function call
   --> crates/jrsonnet-evaluator/src/obj.rs:404:35
    |
404 |         self.get_for(key, self.0.this().unwrap_or(self.clone()))
    |                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| self.clone())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
    = note: `#[warn(clippy::or_fun_call)]` implied by `#[warn(clippy::nursery)]`

Check warning on line 356 in crates/jrsonnet-evaluator/src/obj.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

consider adding a `;` to the last statement for consistent formatting

warning: consider adding a `;` to the last statement for consistent formatting
   --> crates/jrsonnet-evaluator/src/obj.rs:356:4
    |
356 |             member = member.add()
    |             ^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `member = member.add();`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
    = note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 182 in crates/jrsonnet-evaluator/src/obj.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual `Debug` impl does not include all fields

warning: manual `Debug` impl does not include all fields
   --> crates/jrsonnet-evaluator/src/obj.rs:172:1
    |
172 | / impl Debug for OopObject {
173 | |     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
174 | |         f.debug_struct("OopObject")
175 | |             .field("sup", &self.sup)
...   |
181 | |     }
182 | | }
    | |_^
    |
note: this field is unused
   --> crates/jrsonnet-evaluator/src/obj.rs:167:2
    |
167 |     assertions: Cc<Vec<TraceBox<dyn ObjectAssertion>>>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: this field is unused
   --> crates/jrsonnet-evaluator/src/obj.rs:168:2
    |
168 |     assertions_ran: RefCell<GcHashSet<ObjValue>>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: this field is unused
   --> crates/jrsonnet-evaluator/src/obj.rs:170:2
    |
170 |     value_cache: RefCell<GcHashMap<(IStr, Option<WeakObjValue>), CacheValue>>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: consider including all fields in this `Debug` impl
    = help: consider calling `.finish_non_exhaustive()` if you intend to ignore fields
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_fields_in_debug
    = note: `#[warn(clippy::missing_fields_in_debug)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 170 in crates/jrsonnet-evaluator/src/integrations/serde.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary `!=` operation

warning: unnecessary `!=` operation
   --> crates/jrsonnet-evaluator/src/integrations/serde.rs:165:5
    |
165 | /                 if n.fract() != 0.0 {
166 | |                     serializer.serialize_f64(*n)
167 | |                 } else {
168 | |                     let n = *n as i64;
169 | |                     serializer.serialize_i64(n)
170 | |                 }
    | |_________________^
    |
    = help: change to `==` and swap the blocks of the `if`/`else`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else
    = note: `#[warn(clippy::if_not_else)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 90 in crates/jrsonnet-evaluator/src/function/builtin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant clone

warning: redundant clone
  --> crates/jrsonnet-evaluator/src/function/builtin.rs:90:36
   |
90 |                     name: ParamName::new_dynamic(n.to_string()),
   |                                                   ^^^^^^^^^^^^ help: remove this
   |
note: this value is dropped without further use
  --> crates/jrsonnet-evaluator/src/function/builtin.rs:90:35
   |
90 |                     name: ParamName::new_dynamic(n.to_string()),
   |                                                  ^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

Check warning on line 33 in crates/jrsonnet-evaluator/src/function/builtin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use Option::map_or instead of an if let/else

warning: use Option::map_or instead of an if let/else
  --> crates/jrsonnet-evaluator/src/function/builtin.rs:30:3
   |
30 | /         match &self.0 {
31 | |             Some(s) => s.as_bytes() == other.as_bytes(),
32 | |             None => false,
33 | |         }
   | |_________^ help: try: `self.0.as_ref().map_or(false, |s| s.as_bytes() == other.as_bytes())`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_if_let_else
   = note: `#[warn(clippy::option_if_let_else)]` implied by `#[warn(clippy::nursery)]`

Check warning on line 9 in crates/jrsonnet-evaluator/src/function/builtin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
 --> crates/jrsonnet-evaluator/src/function/builtin.rs:9:45
  |
9 | /// Can't have str | IStr, because constant BuiltinParam causes
  |                                             ^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
  |
9 | /// Can't have str | IStr, because constant `BuiltinParam` causes
  |                                             ~~~~~~~~~~~~~~

Check warning on line 9 in crates/jrsonnet-evaluator/src/function/builtin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
 --> crates/jrsonnet-evaluator/src/function/builtin.rs:9:22
  |
9 | /// Can't have str | IStr, because constant BuiltinParam causes
  |                      ^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
note: the lint level is defined here
 --> crates/jrsonnet-evaluator/src/lib.rs:7:2
  |
7 |     clippy::pedantic,
  |     ^^^^^^^^^^^^^^^^
  = note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]`
help: try
  |
9 | /// Can't have str | `IStr`, because constant BuiltinParam causes
  |                      ~~~~~~

Check warning on line 505 in crates/jrsonnet-evaluator/src/evaluate/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant clone

warning: redundant clone
   --> crates/jrsonnet-evaluator/src/evaluate/mod.rs:505:30
    |
505 | ...                   throw!(NoSuchField(key.clone().into_flat(), suggestions))
    |                                             ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> crates/jrsonnet-evaluator/src/evaluate/mod.rs:505:27
    |
505 | ...                   throw!(NoSuchField(key.clone().into_flat(), suggestions))
    |                                          ^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
    = note: `#[warn(clippy::redundant_clone)]` implied by `#[warn(clippy::nursery)]`

Check warning on line 11 in crates/jrsonnet-evaluator/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

pub(crate) import inside private module

warning: pub(crate) import inside private module
  --> crates/jrsonnet-evaluator/src/lib.rs:1:1
   |
1  | / //! jsonnet interpreter implementation
2  | | #![cfg_attr(feature = "nightly", feature(thread_local, type_alias_impl_trait))]
3  | | #![deny(unsafe_op_in_unsafe_fn)]
4  | | #![warn(
...  |
10 | |     explicit_outlives_requirements,
11 | |     noop_method_call,
   | |_
   |
  ::: crates/jrsonnet-evaluator/src/arr/mod.rs:11:1
   |
11 |   pub(crate) use spec::*;
   |   ---------- help: consider using: `pub`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pub_crate
note: the lint level is defined here
  --> crates/jrsonnet-evaluator/src/lib.rs:6:2
   |
6  |     clippy::nursery,
   |     ^^^^^^^^^^^^^^^
   = note: `#[warn(clippy::redundant_pub_crate)]` implied by `#[warn(clippy::nursery)]`