Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tracing Gc with rust-gc #45

Merged
merged 22 commits into from
Jul 4, 2021
Merged

Implement tracing Gc with rust-gc #45

merged 22 commits into from
Jul 4, 2021

Conversation

CertainLach
Copy link
Owner

@CertainLach CertainLach commented Jun 5, 2021 •
edited
Loading

Two bellow issues were fixed by forking rust-gc into https://github.com/CertainLach/jrsonnet-gc

@CertainLach
feat(jrsonnet-types): implement gc
0a2dd7a 
It is currently not possible to implement recursive type, so all tracing
is noop here

Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
feat(jrsonnet-parser): implement gc
6766bfc 
AST can't have cycles, so tracing is noop here

Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
feat(jrsonnet-interner): implement gc
e2e1f7b 
Interned string is backed by Rc<str>, there is nothing to trace here

Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
feat(jrsonnet-evaluator): implement gc
ab385dd 
Some manual Trace/Finalize implementations can be replaced with derives
with Manishearth/rust-gc#116 getting merged

Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
build(bindings): build with gc
46d0b23 
It will build, but some methods is broken for now

Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach CertainLach requested a review from JarvisCraft June 5, 2021 19:08
@CertainLach CertainLach added the enhancement New feature or request label Jun 5, 2021
@CertainLach CertainLach self-assigned this Jun 5, 2021
@CertainLach CertainLach added this to the v0.4.0 milestone Jun 5, 2021
@CertainLach
test: fix NativeCallback usage
765a4d3 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
JarvisCraft
JarvisCraft requested changes Jun 5, 2021
View reviewed changes
crates/jrsonnet-interner/Cargo.toml Outdated Show resolved Hide resolved
crates/jrsonnet-evaluator/src/val.rs Show resolved Hide resolved
crates/jrsonnet-evaluator/src/val.rs Show resolved Hide resolved
@CertainLach CertainLach requested a review from JarvisCraft June 12, 2021 12:43
@CertainLach
Merge branch 'master' into gc-v2
c959f4d 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
doc: remove codegenerated-stdlib
a2ae6ff 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
doc: intrinsic handling is a implementation detail
c36aa5c 
Property __intrinsic_namespace__ shouldn't be handled by anyone

Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
refactor: switch to jrsonnet-gc
a9d1e03 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
feat: gc options
0031c6e 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
test: fix gc import
cda8521 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
doc: remove outdated mimallocator comment
ce623b5 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
build: update flake vendor sha
99a63e2 
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@CertainLach
Merge remote-tracking branch 'origin/master' into gc-v2
56cee93
@CertainLach CertainLach merged commit 8db09e1 into master Jul 4, 2021
@CertainLach CertainLach deleted the gc-v2 branch July 4, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JarvisCraft JarvisCraft Awaiting requested review from JarvisCraft

Assignees

@CertainLach CertainLach

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@CertainLach @JarvisCraft