feat: SQLNESS SLEEP <DURATION_STRING> #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynexia
reviewed
Jun 17, 2024
3 tasks
jiacai2050
reviewed
Jun 18, 2024
jiacai2050
reviewed
Jun 18, 2024
sqlness/src/interceptor/sleep.rs
Outdated
| @@ -74,7 +75,9 @@ impl InterceptorFactory for SleepInterceptorFactory { | |||
| prefix: PREFIX.to_string(), | |||
| msg: format!("Failed to parse milliseconds: {}", e), | |||
| })?; | |||
| Ok(Box::new(SleepInterceptor { milliseconds })) | |||
| Ok(Box::new(SleepInterceptor { | |||
| duration: Duration::from_millis(milliseconds), | |||
There was a problem hiding this comment.
This is not what I mean, I expect the params used in template is duration, like -- SQLNESS SLEEP 15s.
waynexia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some test would require a certain amount of time to output final results(i.e. continous aggregate with some amount of delay)
So it make sense for sqlness to have a
sleepfunction, i.e. mysql&postgre sql both have sleep function, but it could be useful to have a sleep function in test client side anyway.Detailed Changes
add a
-- SQLNESS SLEEP <Milliseconds>to sleep for given time in milliseconds before executing query,which internally just spawn a new thread for sleeping when sleep is needed, this is for simplicity sake, and also to allow cross-runtime
asyncsleep. The overhead of spawn a thread is deemed low since the query is sleeping anyway, the only reason why we can't just blocking sleep directly is because it'sasyncup there so blocking aasynctask make a lot of trouble to anyasyncruntime.Test Plan
a simple test added for waiting given time