Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OWL-2005] Add logging for too late metric received by OWL #402

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

mikelue
Copy link
Contributor

@mikelue mikelue commented Jan 5, 2018

The log is put into "transfer", "judge", and "alarm"

Mike Lue and others added 15 commits January 2, 2018 11:54
# Conflicts:
#	vendor/github.com/Pallinder/go-randomdata/README.md
#	vendor/github.com/Pallinder/go-randomdata/fullprofile.go
#	vendor/github.com/Pallinder/go-randomdata/jsondata.go
#	vendor/github.com/Pallinder/go-randomdata/random_data.go
# Conflicts:
#	vendor/github.com/Pallinder/go-randomdata/README.md
#	vendor/github.com/Pallinder/go-randomdata/fullprofile.go
#	vendor/github.com/Pallinder/go-randomdata/jsondata.go
#	vendor/github.com/Pallinder/go-randomdata/random_data.go
#	vendor/vendor.json
@codecov-io
Copy link

codecov-io commented Jan 5, 2018

Codecov Report

Merging #402 into develop will increase coverage by 0.44%.
The diff coverage is 76.39%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #402      +/-   ##
===========================================
+ Coverage    42.86%   43.31%   +0.44%     
===========================================
  Files          237      243       +6     
  Lines        20449    20775     +326     
===========================================
+ Hits          8766     8999     +233     
- Misses       11365    11448      +83     
- Partials       318      328      +10
Impacted Files Coverage Δ
common/model/metric.go 0% <ø> (ø) ⬆️
common/model/event.go 0% <0%> (ø) ⬆️
common/model/judge.go 0% <0%> (ø) ⬆️
modules/transfer/receiver/rpc/rpc.go 0% <0%> (ø)
modules/transfer/receiver/rpc/rpc_transfer.go 0% <0%> (ø)
modules/transfer/sender/node_rings.go 0% <0%> (ø) ⬆️
modules/transfer/sender/send_tasks.go 0% <0%> (ø) ⬆️
modules/transfer/sender/sender.go 32.63% <0%> (-0.12%) ⬇️
modules/transfer/service/queue_relay.go 100% <100%> (ø)
common/net/listener.go 66.66% <66.66%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 458137b...7071a8c. Read the comment docs.

Copy link
Collaborator

@chyeh chyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants