-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up imports and add missing funcs #1
base: main
Are you sure you want to change the base?
clean up imports and add missing funcs #1
Conversation
…led `add_conf`) and the deluxe, batteries-included version, `add_batteries`. Also adds some tests for this
…all__ and working
Looks like we didn't even need to use |
|
||
|
||
@dataclass | ||
class BatteriesIncludedConf: | ||
class ZenExtras: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should talk about this, it looks like some of the changes here are undoing some purposeful refactoring I put in place
Hello, I just stumbled across this fork -- there are some neat ideas here! Don't hesitate to open Discussion/Issue threads on the main hydra-zen repo if you'd ever like to chat about how hydra-zen can better facilitate your work 😄 . I'm keen to understand the ways people are using the library so that we add high-impact features. (But also no worries if you just want to stay focused on your fork)
Just FYI, hydra-zen 0.9.0 made it possible to effectively specify from hydra_zen import make_custom_builds_fn, builds, to_yaml
Parent = builds(dict, x=1)
cbuilds = make_custom_builds_fn(zen_dataclass={'bases': (Parent,)}) Cheers! |
@rsokl - thanks for reaching out - we were planning on doing exactly that! We built pinned to 0.7 so our thought was to get stuff a little more up to date with the latest version first. I think we have the piece with |
I reverted back to some of the refactoring I did, mainly the bits that split I also updated the notebook you added - the basic interaction with
@shababo good callout - I think that makes sense and kept this change. |
Purpose
This PR is meant to stay within the cellular-longevity fork of hydra-zen. The purpose is to get the
add_conf
andConfMode
functionality working with the latest version of hydra zenTo-do
like
and articulate how we differ from that if we do. See also herebuilds_bases
. Most important item is to recapitulate the functionality of the__call__
method in ourZenExtras
base classZenExtras
was pretty loaded with features; may make sense to strip that down or create a simpler version.store
methods that we put into ourZenExtras