Limb darkening #2047
Limb darkening #2047
Conversation
| @@ -2905,14 +2910,13 @@ ShaderManager::buildAtmosphereFragmentShader(const ShaderProperties& props) | |||
|
|
|||
| // Sum the contributions from each light source | |||
| source += "vec3 color = vec3(0.0);\n"; | |||
| source += "vec3 V = normalize(eyeDir);\n"; | |||
There was a problem hiding this comment.
eyeDir is already normalized since we implemented per-pixel shading.
| @@ -21,12 +21,14 @@ class Texture; | |||
|
|
|||
| struct RenderInfo | |||
| { | |||
| Color color{ 1.0f, 1.0f, 1.0f }; | |||
There was a problem hiding this comment.
reodering is to decrease the struct size
| @@ -460,12 +460,15 @@ class Renderer | |||
| Surface* surface{ nullptr }; | |||
| const Atmosphere* atmosphere{ nullptr }; | |||
| RingSystem* rings{ nullptr }; | |||
| LightingState::EclipseShadowVector* eclipseShadows{ nullptr }; | |||
|
|
|||
| Eigen::Quaternionf orientation{ Eigen::Quaternionf::Identity() }; | |||
There was a problem hiding this comment.
reodering is to decrease the struct size
|
Is it just me, or is there a sprite (or something similar) in the center of the star that increases the brightness and causes some colors to overexpose? |
|
I also think that atmospheres, as a workaround for the glow effect, should be removed |
Yes, there is a big quad (sprite) if front of the Sun. |
|
That's how it looks with stars as scaled disks (in this mode the quad size is much smaller): |
|
|
btw, in old HDR code atmosphere is disabled: #ifndef USE_HDR
Atmosphere atmosphere;
// Use atmosphere effect to give stars a fuzzy fringe
if (star.hasCorona() && rp.geometry == InvalidResource)
{
Color atmColor(color.red() * 0.5f, color.green() * 0.5f, color.blue() * 0.5f);
atmosphere.height = radius * CoronaHeight;
atmosphere.lowerColor = atmColor;
atmosphere.upperColor = atmColor;
atmosphere.skyColor = atmColor;
rp.atmosphere = &atmosphere;
}
else
#endif
rp.atmosphere = NULL; |
What would this look like if used with a normal brightness star texture? |
or even |
Yup that looks lovely. Feels like we can actually use normal brightness textures in default now. |
|
published for testing and getting response.
With atmospheres it looks… weird.