Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guided tour script #1909

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dave-kaye
Copy link
Contributor

Update tour destinations file.

Update tour destinations file.
@dave-kaye
Copy link
Contributor Author

dave-kaye commented Sep 22, 2023

Tour Guide is a menu item in GTK, Qt, win32 and user documentation. It allows various celestial objects to be displayed at the user's request.

The actual tour is performed by reading the file guide.cel in the install directory. This file has not been updated in 16 years. This work updates the file to add several items/areas of interest that have been active since then. It also removes several items that are not supported by the present core data files. Specifically, Albireo is described as a double star, but displays as a single star. The Hyades and Pleiades have more bright stars in photographs than is being displayed, so a check of the data files is in order - but they remain in the tour. Proxima Centauri cannot be seen as part of the Alpha Centauri star system. Additional items of interest can be added to the tour, but the data files do not support them. The work was confined to items in the common data files, not addon data which the user may not have.

This is a suggested edit of the tour guide. Other potential objects (when properly documented in common data files) are:

TRAPPIST-1f (earth-sized exoplanet in habitable zone of star)

Churyumov-Gerasimenko/67P (comet was location of first spacecraft to land on comet - Rosetta/Philae; comet has unique structure and will require model)

This file is displayed to the user, so translation is needed. However, there is no code involved in the file. Therefore if a particular language is not updated, it will not affect the user's system. They will merely see the older version of the guided tour.

This is a draft/suggestion if others want to edit or add/subtract items.

Note: The win32 window for the user interface is a fixed size. Any significant modifications should be checked in that user interface. GTK and Qt interface windows are automatically resized.

@dave-kaye
Copy link
Contributor Author

The multiple commits are due to testing the object distance on multiple systems and user interfaces. They all perform somewhat differently. This is the best compromise I have found. It just affects how large the object is displayed, and zoom features can be readily used to change the distance/object size.

Please merge/flatten all the commits if this request is added to the Celestia source.

@dave-kaye dave-kaye marked this pull request as ready for review December 5, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant