Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scientist`s job names #64

Closed
wants to merge 2 commits into from
Closed

New scientist`s job names #64

wants to merge 2 commits into from

Conversation

quary01
Copy link

@quary01 quary01 commented May 8, 2024

ПР делает что-то умное. Добавлены новые названия для профессий ученых/исследователей, в зависимости от их научной дисциплины.

  • Pull Request полностью завершен, мне не нужна помощь чтобы его закончить.
  • Я внимательно прочитал все свои изменения и багов в них не нашел.
  • Я запускал сервер со своими изменениями локально и все протестировал.

quary01 added 2 commits April 25, 2024 20:38
…"Chemist", "Physicist", "Psychologist", "Memetologist", "Xenogeneticist", "Zoologist", "Microbiologist"")

Added additional names for Senior Scientist job - ("Senior Biologist", "Senior Botanist", "Senior Memetologist", "Senior Physicist")
Added additional names for Junior Scientist job - ("Junior Biologist", "Junior Botanist")
@github-actions github-actions bot added the Code label May 8, 2024
@MrCat15352 MrCat15352 added 🚨Не мёржить!🚨 По каким-то причинам не мержить PR 🔎 Требует рассмотрения 🔍 🧱 Код 🧱 В PR есть код... 📢Не модульно! Код не соответствует требованиям модульности and removed Code labels May 8, 2024
@@ -7,7 +7,7 @@
spawn_positions = 10
supervisors = "the Senior Researchers and Research Director"
economic_power = 4
alt_titles = list("Junior Xenobiologist", "Junior Xenoarcheologist", "Junior Xenobotanist", "Assistant Researcher", "Research Assistant", "Research Intern", "Junior Researcher")
alt_titles = list("Junior Biologist", "Junior Xenoarcheologist", "Junior Botanist", "Assistant Researcher", "Research Assistant", "Research Intern", "Junior Researcher")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну что же, уважаемый, начнем по порядку. Ваш код не соответствует минимальным требованиям модульности

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для начала прочитайте README.md в папке mod_celadon

@@ -7,7 +7,7 @@
spawn_positions = 10
supervisors = "the Senior Researchers and Research Director"
economic_power = 4
alt_titles = list("Junior Xenobiologist", "Junior Xenoarcheologist", "Junior Xenobotanist", "Assistant Researcher", "Research Assistant", "Research Intern", "Junior Researcher")
alt_titles = list("Junior Biologist", "Junior Xenoarcheologist", "Junior Botanist", "Assistant Researcher", "Research Assistant", "Research Intern", "Junior Researcher")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для начала прочитайте README.md в папке mod_celadon

@quary01
Copy link
Author

quary01 commented May 8, 2024

Понял, принял. Код будет переписан в ближайшее время.

@quary01
Copy link
Author

quary01 commented May 10, 2024

Переделал модификацию под условия модульного кода, залью через другой пр, этот закрываю.

@quary01 quary01 closed this May 10, 2024
@quary01 quary01 deleted the New-scientist`s-job-names branch May 10, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📢Не модульно! Код не соответствует требованиям модульности 🔎 Требует рассмотрения 🔍 🚨Не мёржить!🚨 По каким-то причинам не мержить PR 🧱 Код 🧱 В PR есть код...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants