WIP: stateless calculation for display-constant gizmo #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: I'm working on an engine involving manipulating stuffs across real-world semantic maps. Since the map is really large (and the unit length of the engine is different from industrial game engines like UE or unity), sometimes when I zoom out and intend to move something, the arrow/moving plane will shrink until invisible, which makes it impossible to move things around. Same thing happens when translation values become really large (say, 10,000).
Solution: I added up an option, CONSTANCY, which indicates the display mode of gizmo itself. When it's set to SCALE_CONST, the arrow length and plane length will remain world-space constant (becoming larger/smaller when zooming in or not), and it's the default value for added argument - which means that no modification required for existing codes. When it's set to DISPLAY_CONST however, the arrow/plane will remain screen-space constant (no change when zooming in or out).
TODOs: I've done most works for translation and scaling. Rotation is still WIP.