Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2596 In legacy datasets, our brand new ORCID validation may c… #2605

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

lbownik
Copy link
Contributor

@lbownik lbownik commented Dec 5, 2024

…reate confusing errors when trying to save a draft after file edit (upload or changes in metadata or licenses)

@lbownik lbownik requested a review from diasf December 5, 2024 13:53
scripts/database/delete_unfixable_orcids.sql Show resolved Hide resolved
(select datasetfieldparent_id
from datasetfield
where
id in (select datasetfield_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need also a check that the field is of type authorIdentifierScheme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

scripts/database/delete_unfixable_orcids.sql Outdated Show resolved Hide resolved
@diasf diasf assigned lbownik and unassigned diasf Dec 9, 2024
@diasf diasf removed their assignment Dec 10, 2024
lbownik added 2 commits December 10, 2024 11:15
…reate confusing errors when trying to save a draft after file edit (upload or changes in metadata or licenses)
@lbownik lbownik force-pushed the 2596_orcid_fixes_in_legacy_dbs branch from 45619e0 to f8033f5 Compare December 10, 2024 10:15
@lbownik lbownik merged commit 363170c into develop Dec 10, 2024
1 check passed
@lbownik lbownik deleted the 2596_orcid_fixes_in_legacy_dbs branch December 10, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants