review comments

CeON · Apr 18, 2024 · 81c1836 · 81c1836
1 parent b00bc1e
commit 81c1836
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...main/java/edu/harvard/iq/dataverse/authorization/providers/oauth2/impl/OrcidOAuth2AP.java b/...main/java/edu/harvard/iq/dataverse/authorization/providers/oauth2/impl/OrcidOAuth2AP.java
@@ -108,7 +108,7 @@ public ExternalIdpUserRecord getUserRecord(String code, String state, String red
             AuthenticatedUserDisplayInfo orgData = getOrganizationalData(userEndpoint, accessToken.getAccessToken(), service);
             parsed.displayInfo.setAffiliation(orgData.getAffiliation());
             parsed.displayInfo.setPosition(orgData.getPosition());
-            parsed.displayInfo.setOrcId(orcidNumber);
+            parsed.displayInfo.setOrcid(orcidNumber);
 
             return new ExternalIdpUserRecord(getId(), orcidNumber,
                                         parsed.username,

diff --git a/dataverse-webapp/src/main/java/edu/harvard/iq/dataverse/dataset/UserDataFieldFiller.java b/dataverse-webapp/src/main/java/edu/harvard/iq/dataverse/dataset/UserDataFieldFiller.java
@@ -38,7 +38,7 @@ public void fillUserDataInDatasetFields(List<DatasetField> datasetFields, Authen
         String userAffiliation = user.getAffiliation();
         String userAffiliationROR = user.getAffiliationROR();
         String userEmail = user.getEmail();
-        String userOrcidId = user.getOrcId();
+        String userOrcidId = user.getOrcid();
         String todayDate = LocalDate.now(clock).format(DateTimeFormatter.ofPattern("yyyy-MM-dd"));
 
         for (DatasetField dsf : datasetFields) {

diff --git a/dataverse-webapp/src/test/java/edu/harvard/iq/dataverse/dataset/UserDataFieldFillerTest.java b/dataverse-webapp/src/test/java/edu/harvard/iq/dataverse/dataset/UserDataFieldFillerTest.java
@@ -191,7 +191,7 @@ public void fillUserDataInDatasetFields__FILL_AUTHOR() {
     @Test
     public void fillUserDataInDatasetFields__FILL_AUTHOR_WITH_ORCID_AND_ROR() {
         // given
-        user.setOrcId("0000-0001-2345-6789");
+        user.setOrcid("0000-0001-2345-6789");
         user.setAffiliationROR("https://ror.org/04k0tth05");
 
         DatasetFieldType authorIdTypeDatasetFieldType = new DatasetFieldType(DatasetFieldConstant.authorIdType, FieldType.TEXT, false);