Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate upnext to start the next video #374

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Delegate upnext to start the next video #374

merged 1 commit into from
Jan 20, 2020

Conversation

CastagnaIT
Copy link
Owner

@CastagnaIT CastagnaIT commented Dec 10, 2019

Check if this PR fulfills these requirements:

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Feature change (non-breaking change which change behaviour of an existing functionality)
  • Improvement (non-breaking change which improve functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

as title
Ref. im85288/service.upnext#133

Sidenote: makes the transition between video smooth and fast

In case of Feature change / Breaking change:

Describe the current behavior

Describe the new behavior

Screenshots (if appropriate):

@notoco
Copy link
Contributor

notoco commented Dec 11, 2019

Very very fast - great job!

@CastagnaIT CastagnaIT force-pushed the master branch 2 times, most recently from 9262952 to 91bf7ab Compare December 22, 2019 08:50
@dagwieers
Copy link
Contributor

This should work now with Up Next master branch and the upcoming v1.1.0 release !

@CastagnaIT
Copy link
Owner Author

I'll wait till it comes out thanks

@dagwieers
Copy link
Contributor

Don't wait to test it though ;-)

@notoco
Copy link
Contributor

notoco commented Jan 18, 2020

Is there a chance that it will come to the next update? works great on coreelec with the library

@CastagnaIT
Copy link
Owner Author

This is a breaking change, i can't join it before new upnext version is released and updated by users

I waited until today hoping that the new upnext version would be released
but it hasn't been approved yet and i don't know when it will be

i need to release the new nf version now, because there's a critical error that freeze the addon when the library sync is used
will be for the next version

@dagwieers
Copy link
Contributor

As soon as Up Next v1.1.0 is approved, you are good to go.
xbmc/repo-scripts#1276

@dagwieers
Copy link
Contributor

Up Next v1.1.0 has been released.

@CastagnaIT CastagnaIT merged commit 1353f0e into master Jan 20, 2020
@CastagnaIT CastagnaIT deleted the upnext branch January 20, 2020 12:20
@dagwieers
Copy link
Contributor

Maybe we need to add a strict dependency to Up Next v1.1.0 in addon.xml.

@CastagnaIT
Copy link
Owner Author

can be added as optional? Because don't want add it as a mandatory requirement

@dagwieers
Copy link
Contributor

That is indeed a possibility. For the VRT NU add-on we actually have an Integration tab in the settings, where you have an entry to install Up Next and YouTube add-ons. Once installed, the settings turn into and enable/disable integration switch and a link to the setting for each.

add-ons/plugin.video.vrt.nu#548
add-ons/plugin.video.vrt.nu#552

@CastagnaIT
Copy link
Owner Author

I can add that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants