Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infolabels] Make sure that parsed persons have a name #1670

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

CastagnaIT
Copy link
Owner

@CastagnaIT CastagnaIT commented Jan 7, 2024

Check if this PR fulfills these requirements:

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Feature change (non-breaking change which changes behaviour of an existing functionality)
  • Improvement (non-breaking change which improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor (non-breaking performance or readability improvements)

Description

Looks like we have found one of website bugs,
on the second response of the requested menu list
data2.json
the "person" list have the ID 60008166 that have a empty value on "name" field
this should not happens but yeah one of many website weirdness

            "60008166": {
                "id": {
                    "$type": "atom",
                    "value": 60008166
                },
                "name": {
                    "$type": "atom",
                    "value": ""
                }
            },

the change take care that all values taken from "person" list are not empty

fix #1655
superseeds #1664

Copy link
Contributor

@Falke-Design Falke-Design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes totally sense 👍 I can confirm that it solves the error

@CastagnaIT CastagnaIT merged commit c2acdd3 into master Jan 7, 2024
11 checks passed
@CastagnaIT CastagnaIT deleted the fix_empty_person branch January 7, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch list, "Next Page": "Error TypeError: Actor: name property must not be empty"
2 participants