Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] master from xoreos:master #4

Open
wants to merge 240 commits into
base: master
Choose a base branch
from
Open

[pull] master from xoreos:master #4

wants to merge 240 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 3, 2020 •
edited
Loading

See Commits and Changes for more details.

Created by pull[bot]. Want to support this open source service? Please star it : )

@pull pull bot added the ⤵️ pull label Aug 3, 2020
@pull-assistant
Copy link

pull-assistant bot commented Aug 3, 2020 •
edited
Loading

Score: 0.99

Best reviewed: commit by commit

Optimal code review plan (8 warnings)

     DIST: Add libvpx as a dependency to our Arch PKGBUILD

     DIST: Add libvpx as a dependency to our Debian control file

     DIST: Add libvpx as a dependency to our Fedora spec file

     VIDEO: Remove %zu from format strings

     VIDEO: Remove PRIu64 from format strings

     NWN: Use std::abs() instead of abs() for floating point numbers

     RELEASE: This is version 0.0.6

     COMMON: Add ability to set thread names

     DRAGONAGE2: Add Xbox 360 probe

     COMMON: Extend endianness intrinsic functions

     BUILD: Fix building with libvpx using MSVC

     COMMON: Fix calling convention for SetThreadDescription

     AURORA: Fix registering a file as the data base

     AURORA: Add oodle1 decompression

     ACTIONSCRIPT: Add missing register pushs for new object creation

     ACTIONSCRIPT: Add missing register pushs to object method call

     ACTIONSCRIPT: Add preloading of super object to object calls

     ACTIONSCRIPT: Fix super and this variable handling

     TESTS: Add additional actionscript unit test

     IMGUI: Add Dear ImGui, version 1.77

     IMGUI: Add handling for internal GLEW to ImGui OpenGL 3

     IMGUI: Silence another compiler warning in the freetype code

     BUILD: Add ImGui dependency to autotools

     BUILD: Add ImGui dependency to CMake

     BUILD: Increase minimum required SDL2 version to 2.0.4

     EVENTS: Add handling of ImGui SDL events

     GRAPHICS: Add ImGui SDL context handling

     GRAPHICS: Add additional ImGui rendering stage

     GRAPHICS: Add Renderable wrapper class for ImGui UIs

     GRAPHICS: Add ImGui demo for debugging purposes

     GRAPHICS: Prevent ImGui from disappearing in videos

COMMON: Add two way serialization stream

...c/common/serializationstream.h 46% changes removed in COMMON: Use stdint f...

     TESTS: Add unit test for serialization stream

     APPVEYOR: Update xoreos version number

     KOTOR: Fix HUD update on resolution change

     APPVEYOR: Update AppVeyor config to MSVC 2019, x64

     BUILD: Bump C++ standard to C++14

     COMMON: Add deflate compression

     AURORA: Extend ERFWriter with v2.2 support

     TESTS: Add additional tests for V2.0 ERF files

     TESTS: Add unit tests for v2.2 ERF files

     AURORA: Clean up LTRFile

     COMMON: Replace ScopedPtr/ScopedArray with std::unique_ptr

AURORA: Replace ScopedPtr/ScopedArray with std::unique_ptr

src/aurora/talktable_gff.cpp 50% changes removed in AURORA: Replace PtrM...

src/aurora/2dafile.cpp 50% changes removed in AURORA: Replace PtrV...

GRAPHICS: Replace ScopedPtr/ScopedArray with std::unique_ptr

src/graphics/aurora/pltfile.h 67% changes removed in COMMON: Use stdint f...

...rc/graphics/aurora/pltfile.cpp 50% changes removed in COMMON: Use stdint f...

SOUND: Replace ScopedPtr/ScopedArray with std::unique_ptr

src/sound/decoders/wma.cpp 54% changes removed in COMMON: Use stdint f...

     VIDEO: Replace ScopedPtr/ScopedArray with std::unique_ptr

     ENGINES: Replace ScopedPtr/ScopedArray with std::unique_ptr

KOTORBASE: Replace ScopedPtr/ScopedArray with std::unique_ptr

...c/engines/kotorbase/creature.h 50% changes removed in KOTOR: Replace PtrMa...

     ODYSSEY: Replace ScopedPtr/ScopedArray with std::unique_ptr

     NWN: Replace ScopedPtr/ScopedArray with std::unique_ptr

     NWN2: Replace ScopedPtr/ScopedArray with std::unique_ptr

     KOTOR: Replace ScopedPtr/ScopedArray with std::unique_ptr

     KOTOR2: Replace ScopedPtr/ScopedArray with std::unique_ptr

     JADE: Replace ScopedPtr/ScopedArray with std::unique_ptr

WITCHER: Replace ScopedPtr/ScopedArray with std::unique_ptr

src/engines/witcher/module.cpp 67% changes removed in WITCHER: Replace Ptr...

     SONIC: Replace ScopedPtr/ScopedArray with std::unique_ptr

DRAGONAGE: Replace ScopedPtr/ScopedArray with std::unique_ptr

...engines/dragonage/creature.cpp 67% changes removed in DRAGONAGE: Replace P...

DRAGONAGE2: Replace ScopedPtr/ScopedArray with std::unique_ptr

...ngines/dragonage2/creature.cpp 67% changes removed in DRAGONAGE2: Replace ...

     TESTS: Replace ScopedPtr/ScopedArray with std::unique_ptr

     COMMON: Delete ScopedPtr/ScopedArray

     COMMON: Replace SWAP with std::swap

     COMMON: Implement ARRAYSIZE using constexpr

     COMMON: Use [[noreturn]]

     COMMON: Use stdint fixed-type integers

     COMMON: Replace PtrVector with std::vector<std::unique_ptr<>>

     GRAPHICS: Tell DearImGui to not mess with the mouse cursor

     AURORA: Replace PtrVector with std::vector<std::unique_ptr<>>

     GRAPHICS: Replace PtrVector with std::vector<std::unique_ptr<>>

     SOUND: Replace PtrVector with std::vector<std::unique_ptr<>>

     VIDEO: Replace PtrVector with std::vector<std::unique_ptr<>>

     EVENTS: Replace PtrVector with std::vector<std::unique_ptr<>>

     NWN: Replace PtrVector with std::vector<std::unique_ptr<>>

     SONIC: Replace PtrVector with std::vector<std::unique_ptr<>>

     DRAGONAGE: Replace PtrVector with std::vector<std::unique_ptr<>>

     DRAGONAGE2: Replace PtrVector with std::vector<std::unique_ptr<>>

     COMMON: Replace PtrList with std::list<std::unique_ptr<>>

     EVENTS: Replace PtrList with std::list<std::unique_ptr<>>

     ENGINES: Replace PtrList with std::list<std::unique_ptr<>>

     NWN: Replace PtrList with std::list<std::unique_ptr<>>

     NWN2: Replace PtrList with std::list<std::unique_ptr<>>

     KOTOR: Replace PtrList with std::list<std::unique_ptr<>>

     JADE: Replace PtrList with std::list<std::unique_ptr<>>

     WITCHER: Replace PtrList with std::list<std::unique_ptr<>>

     SONIC: Replace PtrList with std::list<std::unique_ptr<>>

     DRAGONAGE: Replace PtrList with std::list<std::unique_ptr<>>

     DRAGONAGE2: Replace PtrList with std::list<std::unique_ptr<>>

     AURORA: Replace PtrMap with std::map<T, std::unique_ptr<>>

     GRAPHICS: Replace PtrMap with std::map<T, std::unique_ptr<>>

     NWN: Replace PtrMap with std::map<T, std::unique_ptr<>>

     NWN2: Replace PtrMap with std::map<T, std::unique_ptr<>>

     KOTOR: Replace PtrMap with std::map<T, std::unique_ptr<>>

     WITCHER: Replace PtrMap with std::map<T, std::unique_ptr<>>

     COMMON: Delete PtrVector/PtrList/PtrMap

     GRAPHICS: Remove default value from MipMap constructor argument

     AURORA: Fix potential segfault when loading 2DA/GDA into the registry

     GRAPHICS: Use std::numeric_limits over literals

     KOTORBASE: Fix ODR violation

     BUILD: Extend boost.m4 to recognize gcc 7.5

     BUILD: Disable -Wunused-const-variable

Powered by Pull Assistant. Last update da659df ... 517b20e. Read the comment docs.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Aug 3, 2020
@vizipi
Copy link

vizipi bot commented Aug 3, 2020 •
edited
Loading

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
77.54% Sven Hesse 4351 870
2.41% Cameron Cawley 21 27
1.07% Michael D. 10 12

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold

Committed file ranks

(click to expand)
  • 72.84%[dists/win32/xoreos.rc]
  • 85.24%[dists/macosx/Info.plist]
  • 30.09%[m4/iconv.m4]
  • 30.09%[m4/lib-link.m4]
  • 30.09%[m4/lib-prefix.m4]
  • 65.42%[src/version/version.cpp]
  • 30.09%[m4/lib-ld.m4]
  • 83.56%[src/common/singleton.h]
  • 96.80%[m4/boost.m4]
  • 75.62%[src/common/debug.h]

    • clone2727 and others added 19 commits August 6, 2020 23:25
    @clone2727 @DrMcCoy
    COMMON: Add ability to set thread names
    de2e9ad 
    Does not work on all platforms, but is a no-op where it doesn't.
    @Nostritius @DrMcCoy
    DRAGONAGE2: Add Xbox 360 probe
    833b918
    @Nostritius @DrMcCoy
    COMMON: Extend endianness intrinsic functions
    a37c6a5
    @ccawley2011
    BUILD: Fix building with libvpx using MSVC
    90bccbe
    @ccawley2011 @DrMcCoy
    COMMON: Fix calling convention for SetThreadDescription
    748262e
    @ccawley2011 @DrMcCoy
    AURORA: Fix registering a file as the data base
    e5189a8
    @Nostritius @DrMcCoy
    AURORA: Add oodle1 decompression
    856ce1e
    @Nostritius @DrMcCoy
    ACTIONSCRIPT: Add missing register pushs for new object creation
    3e51c0d
    @Nostritius @DrMcCoy
    ACTIONSCRIPT: Add missing register pushs to object method call
    6a6dc51
    @Nostritius @DrMcCoy
    ACTIONSCRIPT: Add preloading of super object to object calls
    3cdfe5f
    @Nostritius @DrMcCoy
    ACTIONSCRIPT: Fix super and this variable handling
    f7cf44e
    @Nostritius @DrMcCoy
    TESTS: Add additional actionscript unit test
    56e822c
    @DrMcCoy
    IMGUI: Add Dear ImGui, version 1.77
    09f3c27
    @Nostritius @DrMcCoy
    IMGUI: Add handling for internal GLEW to ImGui OpenGL 3
    64d9b5f
    @DrMcCoy
    IMGUI: Silence another compiler warning in the freetype code
    91a10e1
    @Nostritius @DrMcCoy
    BUILD: Add ImGui dependency to autotools
    e655b3a
    @Nostritius @DrMcCoy
    BUILD: Add ImGui dependency to CMake
    a6206f2
    @DrMcCoy
    BUILD: Increase minimum required SDL2 version to 2.0.4
    b203ad2 
    Dear ImGui uses SDL2 functions that aren't available in older
versions.
    @Nostritius @DrMcCoy
    EVENTS: Add handling of ImGui SDL events
    e0a26b9
    DrMcCoy and others added 30 commits October 6, 2023 03:06
    @DrMcCoy
    BUILD: Delete our own FindIconv.cmake
    87b7d18
    @DrMcCoy
    ACTIONS: Explictly install boost-variant in MSVC workflow
    0a44a4a
    @DrMcCoy
    TESTS: Update Google Test to 1.14.0
    9afff7d
    @DrMcCoy
    MAIN: Deinit the XML subsystem further down
    38c0ede 
    Otherwise, it might already be gone when freeing XML files.
    @DrMcCoy
    DOCS: Update copyright year to 2023
    e92c180
    @DrMcCoy
    BUILD: Set CMake build type to Debug if none specified
    4cc7c00
    @DrMcCoy
    DOCS: Update copyright year to 2024
    c3bf15a
    @clone2727 @DrMcCoy
    BUILD: Remove use of boost::shared_ptr
    0afbbeb
    @clone2727 @DrMcCoy
    SOUND: Remove use of boost::scoped_array
    3b13030
    @clone2727
    BUILD: Switch to C++17 as the default version
    8af35db
    @clone2727
    AURORA: Replace boost::optional with std::optional
    0163347
    @clone2727
    SOUND: Replace boost::variant with std::variant
    3341523
    @clone2727
    AURORA: Remove unneeded boost/shared_ptr.hpp include
    f05bc0b
    @clone2727
    AURORA: Replace boost::variant with std::variant
    43beae3
    @clone2727
    COMMON: Replace boost::make_unsigned with std::make_unsigned
    129cd36
    @clone2727
    GRAPHICS: Replace boost::unordered_set with std::unordered_set
    62bb7d3
    @clone2727 @DrMcCoy
    BUILD: Use the lambda-based BOOST_SCOPE_EXIT
    8b14e4f
    @clone2727 @DrMcCoy
    BUILD: Stop using boost::noncopyable
    558800f
    @clone2727 @DrMcCoy
    VIDEO: Replace boost::static_pointer_cast with std::static_pointer_cast
    9895344
    @clone2727 @DrMcCoy
    COMMON: Remove XOREOS_EXPLICIT_OPERATOR_CONV
    1121966
    @clone2727 @DrMcCoy
    COMMON: Remove strto* compatibility functions
    a9af236
    @clone2727 @DrMcCoy
    ENGINES: Use gnu::format C++11 attribute directly
    a7ec8d9
    @clone2727 @DrMcCoy
    COMMON: Use gnu::format C++11 attribute directly
    293b456
    @clone2727 @DrMcCoy
    COMMON: Remove unused PACKED_STRUCT definition
    97646a7
    @clone2727 @DrMcCoy
    COMMON: Remove unused PLUGIN_EXPORT definition
    3cc452f
    @clone2727 @DrMcCoy
    COMMON: Remove legacy MSVC [v]snprintf macro definition
    b8d60c5
    @DrMcCoy
    BUILD: Update toolchain m4 files
    5c6cf6f
    @DrMcCoy
    BUILD: Extend boost.m4 to recognize new gcc and clang versions
    d62de7e 
    GCC 11.5, 12.4, 13.3, 14.0, 14.1, 14.2
clang 18.0, 19.0
    @DrMcCoy
    COMMON: Remove <> from templated class constructor/destructor
    7f28715
    @DrMcCoy
    DOCS: Update copyright year to 2025
    eaf9852 
    Happy new year!
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    ⤵️ pull 🔍 Ready for Review Pull Request is not reviewed yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @DrMcCoy @clone2727 @Nostritius @ccawley2011 @mirv-sillyfish @lacc97 @drake127