Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Drag&Drop in Internet Explorer 11 #13548

Merged
merged 5 commits into from
Feb 15, 2018
Merged

Fix Drag&Drop in Internet Explorer 11 #13548

merged 5 commits into from
Feb 15, 2018

Conversation

jesusbotella
Copy link
Contributor

@jesusbotella jesusbotella commented Feb 14, 2018

This PR is aimed to fix Drag&Drop feature in IE 11 and lower versions.

The issue was that Dragster, the library that we use to handle Drag&Drop, didn't support IE11 at the time we included it, but it was fixed to support IE11 in this PR.
So, what I did is to update the script we have in the vendor folder to the latest version of the library in order to solve this issue.

I tried to import it from npm, but the package doesn't export the library properly and it doesn't work. ☹️

Related to https://github.com/CartoDB/support/issues/876

Copy link
Contributor

@rubenmoya rubenmoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🇬🇧

@jesusbotella jesusbotella merged commit e3d918b into master Feb 15, 2018
@jesusbotella jesusbotella deleted the 876-ie11-drag&drop branch February 15, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants