Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicated columns in TableModel #916

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jmgaya
Copy link
Contributor

@jmgaya jmgaya commented Oct 1, 2024

Description

Shortcut: (443603)

Works ✅

curl 'https://gcp-us-east1.api.carto.com/v3/sql/carto_dw/model/table?type=query&client=builder&source=SELECT+*+FROM+%60carto-demo-data.demo_tables.newyork_ooh_sample_audience_h3%60&params=%7B%22column%22%3A%5B%22h3%22%2C%22geom%22%2C%22female_20_f727dc_sum%22%5D%2C%22sortDirection%22%3A%22asc%22%2C%22limit%22%3A5%2C%22offset%22%3A0%7D&queryParameters=%5B%5D&filters=%7B%7D&filtersLogicalOperator=and&spatialFiltersMode=intersects' \
  -H 'accept: */*' \
  -H 'authorization: Bearer <place-here-your-token>' \
  -H 'cache-control: no-cache'

Fails 💔

curl 'https://gcp-us-east1.api.carto.com/v3/sql/carto_dw/model/table?type=query&client=builder&source=SELECT+*+FROM+%60carto-demo-data.demo_tables.newyork_ooh_sample_audience_h3%60&params=%7B%22column%22%3A%5B%22h3%22%2C%22geom%22%2C%22female_20_f727dc_sum%22%2C%22h3%22%5D%2C%22sortDirection%22%3A%22asc%22%2C%22limit%22%3A5%2C%22offset%22%3A0%7D&queryParameters=%5B%5D&filters=%7B%7D&filtersLogicalOperator=and&spatialFiltersMode=intersects' \
  -H 'accept: */*' \
  -H 'authorization: Bearer <place-here-your-token>' \
  -H 'cache-control: no-cache'

Type of change

  • Fix

Copy link

github-actions bot commented Oct 1, 2024

Pull Request Test Coverage Report for Build 11122683039

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.977%

Totals Coverage Status
Change from base Build 11102177529: 0.0%
Covered Lines: 2893
Relevant Lines: 3749

💛 - Coveralls

@jmgaya jmgaya marked this pull request as ready for review October 1, 2024 09:41
Copy link

github-actions bot commented Oct 1, 2024

Visit the preview URL for this PR (updated for commit a73653b):

https://cartodb-fb-storybook-react-dev--pr916-bug-443603-preve-vj0shcaj.web.app

(expires Tue, 08 Oct 2024 09:41:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@jmgaya jmgaya merged commit 5e97a96 into master Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants