Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support column formatter for table widget #904

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Support column formatter for table widget #904

merged 2 commits into from
Sep 19, 2024

Conversation

Josmorsot
Copy link
Contributor

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10937044799

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 70.945%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/TableWidgetUI/TableWidgetUI.js 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
packages/react-ui/src/widgets/TableWidgetUI/TableWidgetUI.js 1 66.67%
Totals Coverage Status
Change from base Build 10844407099: -0.01%
Covered Lines: 2840
Relevant Lines: 3684
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit f839246):

https://cartodb-fb-storybook-react-dev--pr904-support-formatte-vtjglram.web.app

(expires Thu, 26 Sep 2024 08:17:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

AlvaroAlmonacidRojo
AlvaroAlmonacidRojo approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@AlvaroAlmonacidRojo AlvaroAlmonacidRojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Josmorsot Josmorsot merged commit 809535b into master Sep 19, 2024
2 checks passed
@Josmorsot Josmorsot deleted the support-formatter-table-widget branch September 19, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroAlmonacidRojo AlvaroAlmonacidRojo AlvaroAlmonacidRojo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josmorsot @AlvaroAlmonacidRojo