Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Legend Widget #837

Merged
merged 69 commits into from
Apr 3, 2024
Merged

New Legend Widget #837

merged 69 commits into from
Apr 3, 2024

Conversation

juandjara
Copy link
Contributor

@juandjara juandjara commented Feb 5, 2024

Description

Shortcut: https://app.shortcut.com/cartoteam/write/IkRvYyI6I3V1aWQgIjY1MWFiYTI0LTZlMTAtNDJkYi04YzU5LWQ5ZjFjMzhjNzc3MCI=

Revamped LegendWidgetUI with new design, advanced styling and logic customization.

This PR has a companion PR in documentation repo

Type of change

  • Refactor

Acceptance

Please describe how to validate the feature or fix

  1. check new design on storybook
  2. match with figma
  3. use in builder

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

Copy link

github-actions bot commented Feb 5, 2024

Pull Request Test Coverage Report for Build 8536679157

Details

  • 166 of 186 (89.25%) changed or added relevant lines in 12 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 68.397%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/legend/LegendLayerTitle.js 9 10 90.0%
packages/react-ui/src/widgets/legend/LegendOpacityControl.js 7 9 77.78%
packages/react-ui/src/widgets/legend/LegendLayer.js 44 47 93.62%
packages/react-ui/src/widgets/legend/LegendWidgetUI.js 8 12 66.67%
packages/react-ui/src/widgets/legend/LegendLayerVariable.js 14 24 58.33%
Files with Coverage Reduction New Missed Lines %
packages/react-ui/src/theme/sections/components/forms.js 7 27.59%
Totals Coverage Status
Change from base Build 8389817061: -0.2%
Covered Lines: 2679
Relevant Lines: 3571

💛 - Coveralls

Copy link

github-actions bot commented Feb 5, 2024

Visit the preview URL for this PR (updated for commit 1bd89d4):

https://cartodb-fb-storybook-react-dev--pr837-feature-new-lege-zjj9wlde.web.app

(expires Wed, 10 Apr 2024 09:56:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@juandjara juandjara changed the title Feature/new legend New Legend Widget Feb 5, 2024
Copy link
Contributor

@aaranadev aaranadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vmilan vmilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left several comments, but most of them are the same, minor suggestions in different parts

packages/react-ui/src/widgets/legend/LegendLayer.js Outdated Show resolved Hide resolved
packages/react-ui/src/widgets/legend/LegendLayer.js Outdated Show resolved Hide resolved
packages/react-ui/src/widgets/legend/LegendLayer.js Outdated Show resolved Hide resolved
packages/react-ui/src/widgets/legend/LegendLayer.js Outdated Show resolved Hide resolved
packages/react-ui/src/widgets/legend/LegendLayerTitle.js Outdated Show resolved Hide resolved
@juandjara juandjara requested a review from vmilan March 18, 2024 17:12
Copy link
Contributor

@padawannn padawannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing in Builder, undo this commit e1f2902 before merge

@padawannn padawannn force-pushed the feature/new-legend branch 2 times, most recently from a9d42e9 to 1bd89d4 Compare April 3, 2024 09:50
@padawannn padawannn merged commit 006114d into master Apr 3, 2024
3 checks passed
@padawannn padawannn deleted the feature/new-legend branch April 3, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants