-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Legend Widget #837
New Legend Widget #837
Conversation
Pull Request Test Coverage Report for Build 8536679157Details
💛 - Coveralls |
Visit the preview URL for this PR (updated for commit 1bd89d4): https://cartodb-fb-storybook-react-dev--pr837-feature-new-lege-zjj9wlde.web.app (expires Wed, 10 Apr 2024 09:56:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
packages/react-ui/src/widgets/new-legend/LegendLayerVariable.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/new-legend/LegendLayerVariable.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/new-legend/LegendLayerVariable.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/new-legend/LegendOpacityControl.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/new-legend/LegendWidgetUI.styles.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left several comments, but most of them are the same, minor suggestions in different parts
packages/react-ui/src/widgets/legend/legend-types/LegendIcon.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/legend/legend-types/LegendProportion.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/legend/legend-types/LegendRamp.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/legend/legend-types/LegendRamp.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing in Builder, undo this commit e1f2902 before merge
a9d42e9
to
1bd89d4
Compare
Description
Shortcut: https://app.shortcut.com/cartoteam/write/IkRvYyI6I3V1aWQgIjY1MWFiYTI0LTZlMTAtNDJkYi04YzU5LWQ5ZjFjMzhjNzc3MCI=
Revamped LegendWidgetUI with new design, advanced styling and logic customization.
This PR has a companion PR in documentation repo
Type of change
Acceptance
Please describe how to validate the feature or fix
Basic checklist