Skip to content

Commit

Permalink
v1.0.0 rc.3
Browse files Browse the repository at this point in the history
* chore: update @carto/react-* packages to rc.3
* doc: improve developers info for release
* chore: simplify ci
* chore: remove cypress dep from template clients
  • Loading branch information
VictorVelarde authored Mar 22, 2021
1 parent 9bf5782 commit da35279
Show file tree
Hide file tree
Showing 7 changed files with 49 additions and 44 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@

name: CI

on: [push]
on:
push:
branches:
- master
pull_request:

jobs:
test-sample-app:
Expand Down
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# CHANGELOG

## Unreleased
## Not released

## 1.0.0-rc.3 (2021-03-23)
- Fix general React warning on SharedArrayBuffer [#218](https://github.com/CartoDB/carto-react-template/pull/218)
- Integrate carto-react lib with workers support [#219](https://github.com/CartoDB/carto-react-template/pull/219)

Expand Down
15 changes: 9 additions & 6 deletions DEVELOPERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,21 @@ npx create-react-app test-template --template file:./carto-react-template/templa

Follow these steps:

1. Open a new branch for the release, eg. release-v1.0.0-rc.2
1. Open a new branch for the release from master, eg. `git checkout -b release-v1.0.0-rc.3`
2. For each template:
- remove the link to @carto/react-* packages with `yarn unlink-carto-react`
- ensure latest references with `yarn`. Delete previously node_modules if you feel a bit unsure :)
- launch the app, with `yarn start`
- test cypress locally, with `yarn cy:run`
- manual review from browser (see errors & warnings)
- from template root folder `yarn clean`
- from template root folder (eg. template-skeleton), run `yarn clean`
- copy the hygen templates, so you can test them inside the client project
- use create-react-app to build a project
- test cra project result as a user, including hygen generators
3. Bump manually package version in package.json (root level --> package.json & inside template --> package.dev.json)
4. Update changelog: rename 'Unrelased' to new version, eg 1.0.0-rc.2 (2021-03-12)
5. Push branch to remote to run CI (all test green)
6. Execute the release command, for each template, from its **base folder**: `yarn release`.
3. Bump manually package version in package.json (root level --> package.json & inside template --> package.dev.json), checking @carto/react-* package versions are also correct.
4. Update changelog: rename 'Unrelased' to new version, eg 1.0.0-rc.3 (2021-03-23)
5. Push branch to remote to run CI (all test green) with `git push`
6. Execute the release command, for each template, from its **base folder** (eg. template-sample-app): `yarn release`.

```bash
cd template-sample-app
Expand Down
18 changes: 8 additions & 10 deletions template-sample-app/template.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"package": {
"dependencies": {
"@carto/react-api": "1.0.0-rc.2",
"@carto/react-auth": "1.0.0-rc.2",
"@carto/react-basemaps": "1.0.0-rc.2",
"@carto/react-core": "1.0.0-rc.2",
"@carto/react-redux": "1.0.0-rc.2",
"@carto/react-ui": "1.0.0-rc.2",
"@carto/react-widgets": "1.0.0-rc.2",
"@carto/react-workers": "1.0.0-rc.2",
"@carto/react-api": "1.0.0-rc.3",
"@carto/react-auth": "1.0.0-rc.3",
"@carto/react-basemaps": "1.0.0-rc.3",
"@carto/react-core": "1.0.0-rc.3",
"@carto/react-redux": "1.0.0-rc.3",
"@carto/react-ui": "1.0.0-rc.3",
"@carto/react-widgets": "1.0.0-rc.3",
"@carto/react-workers": "1.0.0-rc.3",
"@formatjs/intl-getcanonicallocales": "^1.5.3",
"@formatjs/intl-locale": "^2.4.14",
"@formatjs/intl-numberformat": "^6.1.4",
Expand All @@ -17,13 +17,11 @@
"@material-ui/icons": "^4.11.2",
"@material-ui/lab": "4.0.0-alpha.57",
"@reduxjs/toolkit": "^1.5.0",
"@testing-library/cypress": "^7.0.3",
"@testing-library/jest-dom": "^5.11.9",
"@testing-library/react": "^11.2.3",
"@testing-library/user-event": "^12.6.2",
"@turf/bbox-polygon": "^6.3.0",
"@turf/boolean-intersects": "^6.3.0",
"cypress": "^6.3.0",
"deck.gl": "8.4.10",
"echarts": "^4.9.0",
"echarts-for-react": "^2.0.16",
Expand Down
16 changes: 8 additions & 8 deletions template-sample-app/template/package.dev.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
"version": "1.0.0-rc.3",
"private": true,
"dependencies": {
"@carto/react-api": "1.0.0-rc.2",
"@carto/react-auth": "1.0.0-rc.2",
"@carto/react-basemaps": "1.0.0-rc.2",
"@carto/react-core": "1.0.0-rc.2",
"@carto/react-redux": "1.0.0-rc.2",
"@carto/react-ui": "1.0.0-rc.2",
"@carto/react-widgets": "1.0.0-rc.2",
"@carto/react-workers": "1.0.0-rc.2",
"@carto/react-api": "1.0.0-rc.3",
"@carto/react-auth": "1.0.0-rc.3",
"@carto/react-basemaps": "1.0.0-rc.3",
"@carto/react-core": "1.0.0-rc.3",
"@carto/react-redux": "1.0.0-rc.3",
"@carto/react-ui": "1.0.0-rc.3",
"@carto/react-widgets": "1.0.0-rc.3",
"@carto/react-workers": "1.0.0-rc.3",
"@formatjs/intl-getcanonicallocales": "^1.5.3",
"@formatjs/intl-locale": "^2.4.14",
"@formatjs/intl-numberformat": "^6.1.4",
Expand Down
18 changes: 8 additions & 10 deletions template-skeleton/template.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"package": {
"dependencies": {
"@carto/react-api": "1.0.0-rc.2",
"@carto/react-auth": "1.0.0-rc.2",
"@carto/react-basemaps": "1.0.0-rc.2",
"@carto/react-core": "1.0.0-rc.2",
"@carto/react-redux": "1.0.0-rc.2",
"@carto/react-ui": "1.0.0-rc.2",
"@carto/react-widgets": "1.0.0-rc.2",
"@carto/react-workers": "1.0.0-rc.2",
"@carto/react-api": "1.0.0-rc.3",
"@carto/react-auth": "1.0.0-rc.3",
"@carto/react-basemaps": "1.0.0-rc.3",
"@carto/react-core": "1.0.0-rc.3",
"@carto/react-redux": "1.0.0-rc.3",
"@carto/react-ui": "1.0.0-rc.3",
"@carto/react-widgets": "1.0.0-rc.3",
"@carto/react-workers": "1.0.0-rc.3",
"@formatjs/intl-getcanonicallocales": "^1.5.3",
"@formatjs/intl-locale": "^2.4.14",
"@formatjs/intl-numberformat": "^6.1.4",
Expand All @@ -17,13 +17,11 @@
"@material-ui/icons": "^4.11.2",
"@material-ui/lab": "4.0.0-alpha.57",
"@reduxjs/toolkit": "^1.5.0",
"@testing-library/cypress": "^7.0.3",
"@testing-library/jest-dom": "^5.11.9",
"@testing-library/react": "^11.2.3",
"@testing-library/user-event": "^12.6.2",
"@turf/bbox-polygon": "^6.3.0",
"@turf/boolean-intersects": "^6.3.0",
"cypress": "^6.3.0",
"deck.gl": "8.4.10",
"echarts": "^4.9.0",
"echarts-for-react": "^2.0.16",
Expand Down
16 changes: 8 additions & 8 deletions template-skeleton/template/package.dev.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
"version": "1.0.0-rc.3",
"private": true,
"dependencies": {
"@carto/react-api": "1.0.0-rc.2",
"@carto/react-auth": "1.0.0-rc.2",
"@carto/react-basemaps": "1.0.0-rc.2",
"@carto/react-core": "1.0.0-rc.2",
"@carto/react-redux": "1.0.0-rc.2",
"@carto/react-ui": "1.0.0-rc.2",
"@carto/react-widgets": "1.0.0-rc.2",
"@carto/react-workers": "1.0.0-rc.2",
"@carto/react-api": "1.0.0-rc.3",
"@carto/react-auth": "1.0.0-rc.3",
"@carto/react-basemaps": "1.0.0-rc.3",
"@carto/react-core": "1.0.0-rc.3",
"@carto/react-redux": "1.0.0-rc.3",
"@carto/react-ui": "1.0.0-rc.3",
"@carto/react-widgets": "1.0.0-rc.3",
"@carto/react-workers": "1.0.0-rc.3",
"@formatjs/intl-getcanonicallocales": "^1.5.3",
"@formatjs/intl-locale": "^2.4.14",
"@formatjs/intl-numberformat": "^6.1.4",
Expand Down

1 comment on commit da35279

@vercel
Copy link

@vercel vercel bot commented on da35279 Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.