Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tilesets): Support widget calculations on tilesets #50

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

donmccurdy
Copy link
Member

@donmccurdy donmccurdy commented Dec 31, 2024

Changes:

  • Migrate local calculations from C4R
  • Port local calculations to TypeScript
    • In some cases the types were not obvious, particularly required vs. optional parameters and overloaded types (see: SortColumns). I've used strict TS types where possible, and generally tried to make parameters required for internal functions so that defaults are applied only once at top-level calls.
  • Migrate unit tests from C4R
  • Add WidgetTilesetSource class
  • Refactor WidgetSource class hierarchy:
    • WidgetSource
      • WidgetRemoteSource
        • WidgetTableSource
        • WidgetQuerySource
      • WidgetTilesetSource
  • Add tileset example

Remaining:

  • test with H3 and quadbin tilesets
  • publish alpha release
  • include Web Workers

@donmccurdy donmccurdy force-pushed the feat/sc-459604/tileset-widgets branch 2 times, most recently from 82c8732 to 2370ee5 Compare January 2, 2025 23:23
@donmccurdy donmccurdy changed the title feat(widgets): Add support for tileset sources and local widget calculations feat(tilesets): Add support for tileset sources and local widget calculations Jan 3, 2025
@donmccurdy donmccurdy added the enhancement New feature or request label Jan 3, 2025
@donmccurdy donmccurdy marked this pull request as ready for review January 3, 2025 17:39
@donmccurdy donmccurdy force-pushed the feat/sc-459604/tileset-widgets branch from ececac5 to 5ceaca0 Compare January 9, 2025 19:59
@donmccurdy donmccurdy force-pushed the feat/sc-459604/tileset-widgets branch from 9affa4f to d7ff039 Compare January 15, 2025 20:37
@donmccurdy donmccurdy changed the title feat(tilesets): Add support for tileset sources and local widget calculations feat(tilesets): Support widget calculations on tilesets Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant