Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support aggregationExp for Table/Query Sources #48

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Support aggregationExp for Table/Query Sources #48

merged 2 commits into from
Dec 26, 2024

Conversation

jmgaya
Copy link
Contributor

@jmgaya jmgaya commented Dec 23, 2024

No description provided.

@jmgaya jmgaya requested a review from donmccurdy December 23, 2024 15:13
@jmgaya jmgaya marked this pull request as ready for review December 23, 2024 15:15
@jmgaya jmgaya requested review from zbigg and padawannn December 26, 2024 08:48
donmccurdy
donmccurdy approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment/question on the docs, otherwise LGTM!

src/sources/types.ts Outdated Show resolved Hide resolved
@jmgaya jmgaya requested a review from donmccurdy December 26, 2024 15:24
@jmgaya jmgaya merged commit bce115d into main Dec 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

@zbigg zbigg Awaiting requested review from zbigg

@padawannn padawannn Awaiting requested review from padawannn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmgaya @donmccurdy