Clean up TODOs

.gitignore

@@ -3,9 +3,6 @@ build
 coverage
 custom-elements.json
 
-# TODO: Prevent type defs being written for tests.
-test/**/*.d.ts
-
 # https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
 .pnp.*
 .yarn/*

examples/01-pure-js/pure-js.ts

@@ -97,11 +97,10 @@ function updateWidgets() {
  * INITIALIZATION
  */
 
-// TODO: Improve type definitions.
 function bindWidget(selector: string): Widget {
   const widget = document.querySelector<Widget>(selector)!;
 
-  (widget as any).addEventListener('filter', (event: FilterEvent) => {
+  widget.addEventListener('filter', (event: FilterEvent) => {
     filters = event.detail.filters;
     updateSources();
   });

examples/02-react/app.tsx

@@ -12,6 +12,7 @@ import {
 } from '../components/index-react.js';
 import {MapView} from '@deck.gl/core';
 import {VectorTileLayer} from '@deck.gl/carto';
+import {FilterEvent} from '../components/types.js';
 
 const MAP_VIEW = new MapView({repeat: true});
 const MAP_STYLE =
@@ -80,7 +81,7 @@ export function App(): JSX.Element {
           header="Store type"
           operation="count"
           column="storetype"
-          onfilter={(e) => setFilters((e as any).detail.filters)} // TODO: types
+          onfilter={(e) => setFilters((e as FilterEvent).detail.filters)}
         ></CategoryWidget>
 
         <PieWidget
@@ -89,7 +90,7 @@ export function App(): JSX.Element {
           header="Store type"
           operation="count"
           column="storetype"
-          onfilter={(e) => setFilters((e as any).detail.filters)} // TODO: types
+          onfilter={(e) => setFilters((e as FilterEvent).detail.filters)}
         ></PieWidget>
 
         <TableWidget

examples/components/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../tsconfig.json",
   "include": ["**/*.ts"],
   "compilerOptions": {
     "plugins": [

examples/components/widgets/category-widget.ts

@@ -57,7 +57,7 @@ export class CategoryWidget extends BaseWidget {
         spatialFilter: this.getSpatialFilterOrViewState(),
         operation,
         column,
-      }); // TODO: signal
+      });
     },
     args: () =>
       [
@@ -156,7 +156,7 @@ export class CategoryWidget extends BaseWidget {
     categories.sort((a, b) => (a.value > b.value ? -1 : 1));
 
     const data = categories.map(({name, value}, index) => {
-      let color = DEFAULT_PALETTE[index]; // TODO: >8 categories allowed?
+      let color = DEFAULT_PALETTE[index % DEFAULT_PALETTE.length];
       if (this._filterValues.length > 0) {
         color = this._filterValues.includes(name) ? color : '#cccccc';
       }

examples/components/widgets/formula-widget.ts

@@ -60,7 +60,7 @@ export class FormulaWidget extends BaseWidget {
         operation,
         column,
         spatialFilter: this.getSpatialFilterOrViewState(),
-      }); // TODO: signal
+      });
       return response.value;
     },
     args: () =>

examples/components/widgets/histogram-widget.ts

@@ -59,7 +59,7 @@ export class HistogramWidget extends BaseWidget {
         column,
         operation,
         ticks,
-      }); // TODO: signal
+      });
     },
     args: () =>
       [

examples/components/widgets/pie-widget.ts

@@ -22,7 +22,7 @@ export class PieWidget extends CategoryWidget {
     categories.sort((a, b) => (a.value > b.value ? -1 : 1));
 
     const data = categories.map(({name, value}, index) => {
-      let color = DEFAULT_PALETTE[index]; // TODO: >8 categories allowed?
+      let color = DEFAULT_PALETTE[index % DEFAULT_PALETTE.length];
       if (this._filterValues.length > 0) {
         color = this._filterValues.includes(name) ? color : '#cccccc';
       }

examples/components/widgets/scatter-widget.ts

@@ -66,7 +66,7 @@ export class ScatterWidget extends BaseWidget {
         xAxisJoinOperation,
         yAxisColumn,
         yAxisJoinOperation,
-      }); // TODO: signal
+      });
     },
     args: () =>
       [

examples/components/widgets/table-widget.ts

@@ -58,7 +58,7 @@ export class TableWidget extends BaseWidget {
       return widgetSource.getTable({
         columns,
         spatialFilter: this.getSpatialFilterOrViewState(),
-      }); // TODO: signal
+      });
     },
     args: () =>
       [this.data, this.columns, this.viewState, this.spatialFilter] as const,