Support geometry collection in Quadint polyfill

[vdelacruzb]

No description provided.

[shortcut-integration]

This pull request has been linked to Clubhouse Story #173145: ST_ASQUADINT_POLYFILL not supporting GEOMETRY COLLECTIONS.

[vdelacruzb]

Made tests in SF use ST_ASQUADINT_POLYFILL and also added duplicated features to tests to double check that the resulting array doesn't change as we remove duplicates.

[Jesus89]

LGTM!

[github-actions]

Deployed in project bqcartost-core-150: https://console.cloud.google.com/bigquery?project=bqcartost-core-150

[Jesus89]

I've tested this in staging and found the following error:

SELECT quadkey.ST_ASQUADINT_POLYFILL(geom,16) FROM `cartobq.testtables.polygons_800k` LIMIT 1000
-- Error: NULL argument passed to UDF at UDF$1(STRING, INT64) line 3, columns 8-9

This is because the dataset contains NULL geographies and this ends up in NULL GeoJSON. I think we should cover this case to avoid the bug, and return [] in that case. cc @martejpad

[vdelacruzb]

I've tested this in staging and found the following error:

SELECT quadkey.ST_ASQUADINT_POLYFILL(geom,16) FROM `cartobq.testtables.polygons_800k` LIMIT 1000
-- Error: NULL argument passed to UDF at UDF$1(STRING, INT64) line 3, columns 8-9

This is because the dataset contains NULL geographies and this ends up in NULL GeoJSON. I think we should cover this case to avoid the bug, and return [] in that case. cc @martejpad

We are returning this Error in purpose, I remember we talked about that months ago but it can be removed for sure, and replace it by an empty array. We should take the same approach in other functions then TOPARENT, TOCHILDREN...

[vdelacruzb]

The NULL issue is related with #148.

I thought Bigquery's Safe Prefix was also working with UDFs. Should we request that? If it was supported all the functions should return Error by default.

[Jesus89]

OK then. We can merge it as it is and create a ticket in CH to update this behavior in all the functions if required and possible.

[Jesus89]

But remember to update the changelog first

[github-actions]

Project bqcartost-core-150 deleted! 🔥