Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port, videos and pictures in pop-up #29

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

NicolasGrosjean
Copy link
Contributor

Continue to develop #15 by adding port, videos and pictures.

The only day there are videos and pictures data is the 20th September 2021.

I have not added the drop-down to hide/show videos and pictures because I am not comfortable with Vue.JS. So if it is easy to add for you, do not hesitate to add it.

@NicolasGrosjean
Copy link
Contributor Author

image

@0live 0live self-requested a review June 3, 2022 14:39
Copy link
Contributor

@0live 0live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai ajouté un dropdown pour essayer, mais ça ne rends pas très bien au final. Vu que ça fait changer la taille de la popup quand les photos apparaissent, la popup se déplace vers le haut pour rester centrer à l'écran. De plus, le fait que le dropdown soit tout en bas de la popup peut donner l'impression à l'utilisateur qu'il n'y a pas de photos. Je laisserais comme ça pour l'instant.

Add hard coded pictures and videos when there is a media link (only one in the current data)
Displays images and videos set in the Google Sheet
@NicolasGrosjean NicolasGrosjean merged commit 609e9cb into main Jun 6, 2022
@NicolasGrosjean NicolasGrosjean deleted the feature/more-pop-up-data branch June 6, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants