Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple pop-up #16

Merged
merged 3 commits into from
Jun 12, 2021
Merged

Simple pop-up #16

merged 3 commits into from
Jun 12, 2021

Conversation

NicolasGrosjean
Copy link
Contributor

Implement a pop-up with some data for #15, waiting the @damiendevienne images.

image

image

@NicolasGrosjean NicolasGrosjean changed the base branch from main to develop May 30, 2021 15:20
Add icons and missing stats
@NicolasGrosjean
Copy link
Contributor Author

With the icons, the pop-up is better.

image

image

I have 2 issues and I don't know how to solve them :

  • The share button to open the application on it
  • The CSS links between minors and unaccompagnied/children (we will have the same issue for Encart des thématiques clés #9 )

@regazzoj
Copy link
Contributor

I couldn't figure out how to achieve your second issue. I was thinking of SVG and just draw a line/path, but didn't have time to do so.

For the first issue, I need to think about it, but I am thinking of just give the state in the URL and remake the state according to URL parameters. I don't know if we need a lot of things to be shared.
I know it doesn't really fit well, but it could be a workaround for a first version.

I let you merge your PR, thanks for you work (:

I will work on some refacto on my side and trying to implement SVG to draw connection between elements.

@NicolasGrosjean NicolasGrosjean merged commit e57276f into develop Jun 12, 2021
@regazzoj regazzoj deleted the feature/pop-up branch June 20, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants