Adding optionnal headers to saveImage and saveVideo #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VOIDCRUSHER
reviewed
Jan 20, 2021
| print(url); | ||
| http.Client _client = new http.Client(); | ||
| var req = await _client.get(Uri.parse(url)); | ||
| var req = headers != null ? await _client.get(Uri.parse(url), headers: headers) : await _client.get(Uri.parse(url)); |
There was a problem hiding this comment.
Does this break without the explicit null check? Seems from the implementation that it's not necessary.
There was a problem hiding this comment.
Yeah i overreacted and it doesn't break out without the null check i should correct that thax for highlighting it !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently opened an issue (#78 ), about adding optionnal headers to the saveImage / saveVideo methods, because sometimes you want to download images or ressources that are protected, by a bearer token for example. I simply added optionnal parameter to the saveImage and saveVideo methods which is an header parameter.
If a header parameter is here, it will be used by the get method.
Hope it will helps :)