Safe upgrades: Add healthcheck function and call it when upgrading a contract #116 -Malachi PR #122
Conversation
|
Fixed health check tests. Everything works fine now. |
src/health.cairo
Outdated
| fn assert_correct_contract_type( | ||
| self: @ContractState, proposed_contract_type: felt252, previous_contract_type: u64 | ||
| ) -> bool { | ||
| // Check if the proposed contract type is compatible with the previous contract type | ||
| if proposed_contract_type == 1 && previous_contract_type == 1 { | ||
| // Generic contract upgrade is allowed | ||
| true | ||
| } else if proposed_contract_type == 3 && previous_contract_type == 3 { | ||
| // Airdrop upgrade is allowed | ||
| true | ||
| } else if proposed_contract_type == 5 && previous_contract_type == 5 { | ||
| // Custom proposal is allowed | ||
| true | ||
| } else if proposed_contract_type == 6 && previous_contract_type == 6 { | ||
| // Arbitrary proposal is allowed | ||
| true | ||
| } else if (proposed_contract_type == 0 && previous_contract_type == 0) | ||
| || (proposed_contract_type == 2 && previous_contract_type == 2) { | ||
| false | ||
| } else { | ||
| false | ||
| } | ||
| } |
There was a problem hiding this comment.
I would expect a function with assert in its name to panic if it is not the correct contract type. Either name is is_correct_contract_type and return bool or keep it like this but make it panic if it's not the correct type.
There was a problem hiding this comment.
I hope this isnt a stupid question-
I know I have to remove the get_latest_prop_id but I'm now confused. Is the way I'm approaching the health check so far the way you were expecting? Or is it completely wrong since I only need to run this for generic proposals. And in this case, what are the checks to ensure that a generic proposal is compatible with the governance state? (would it be things like payload, to_upgrade, or simply that it has a valid quorum, vote time etc.)
Im now confused on what the healthcheck is...
scobi7
force-pushed
the
scobi-safeUpgrades
branch
from
1d81911 to
ab27fe4
Compare
No description provided.