Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update volunteer page #515

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Update volunteer page #515

merged 7 commits into from
Sep 2, 2024

Conversation

MathyouMB
Copy link
Member

Updated version of the volunteer page with additional information on how to get involved.

@MathyouMB MathyouMB requested a review from a team as a code owner August 30, 2024 11:01
@MathyouMB MathyouMB self-assigned this Aug 30, 2024
Copy link
Contributor

github-actions bot commented Aug 30, 2024

🎊 PR Preview 112118b has been successfully built and deployed to https://CarletonComputerScienceSociety-website-build_preview-pr-515.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 8.5%, saving 29.99 KB.

Filename Before After Improvement Visual comparison
static/images/general/volunteer_2.jpg 354.00 KB 324.01 KB -8.5% View diff

483 images did not require optimisation.


## Zero Commitment Volunteering

For those who want to contribute without a firm commitment, these oppurtunities are perfect.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo:" "oppurtunities" -> "opportunities"

@@ -6,7 +6,7 @@
<div class="page-section page-section-grid-priority">
<div
class="page-section-image page-section-grid-secondary"
style='background-image: url("/images/general/volunteer.jpg")'
style='background-image: url("/images/general/volunteer_2.jpg")'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a higher resolution version or similar picture?

image

Also, since the bulk of this page is a slim center aligned text box, should we have the "hero section", then the image in the vertical hierarchy?

@ryangchung
Copy link
Collaborator

Otherwise LGTM!

@MathyouMB MathyouMB merged commit c3f0d75 into master Sep 2, 2024
4 checks passed
@MathyouMB MathyouMB deleted the mmb/volunteer-page-updates branch September 2, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants