Added Dump Memory Feature #79
Conversation
|
Hello @CanBusHack / @LemmonAuto. There seems to be quite a bit of action in this PR with commits still being added - please let me know when it is in a state ready for review, and I will be happy to take a closer look 👍 Please note that a PR should preferably fix/add one bug/issue/feature. |
|
This should only add one feature! But yes there were some bugs that were squashed with it. I'll try to keep it seperate from now on. I found one more bug that needs to be fixed for the PR. Updating that now. |
|
Looks like I've commited what I can. Please feel free to review. |
|
Is this still up for review, can we fix it and pull it? |
Adding this feature might very well be useful 👍
This is a separate feature and should therefore preferably be done as a separate PR. We might already have one on the way, see discussion in #84 The PR also has a bunch of conflicts in need of resolving. |
|
Are you looking for me to solve these conflicts? What are they specifically? |
Add new feature, utilizing the UDS service Read Memory by Address to Dump memory, developed by @CanBusHack in a pull request of the original repo CaringCaribou#79 Co-Authored-By: CanBusHack <[email protected]>
I copied dump_dids and recreated it to support dump memory using the uds.read_memory_by_address method.
I updated the can.Bus() functions to include both "Channel" and "Interface" (optional).
Formatting fixes.